Feat/help thread stats by ankitsmt211 · Pull Request #1361 · Together-Java/TJ-Bot

ankitsmt211 · 2025-12-21T10:59:06Z

continues work of #1159 with /help-stats slash command, refactors to fetch stats from database instead of discord APIs. Also adds stats to embed for better UX.

embed color has three states

GREEN (high response rates)
ORANGE (medium response rates)
RED(low response rates)

edited: also adds per channel limit, can be used once per minute.

replaces fetching metrics directly from database instead of discord, uses embed for showcases stats and making duration as optional choice in terms of days

spotless fixes, helper for calculating duration in seconds between datetime fields to be more compliant with code quality tests

change emojis to unicode character constants with descriptive names, single/blank line of space to be more intentional and clear

tj-wazei

I think this is fine, just some small changes to the imports.

application/src/main/java/org/togetherjava/tjbot/features/Features.java

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadStatsCommand.java

SquidXTV

Good job!

I kinda abused some review comments for future ideas and questions.

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadStatsCommand.java

…/HelpThreadStatsCommand.java use a more simpler way to get days and a fallback if user entered option is missing Co-authored-by: Connor Schweighöfer <squidxtv@gmail.com>

since when saving thread meta data, participant count excludes author which means thread with 0 participants should be counted as ghost threads instead of single participant

to avoid users from spamming, this adds a cooldown period of a min per channel

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadStatsCommand.java

uses Duration instance for expiration of cache items instead of seperate values for ease of maintenance and clarity

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadStatsCommand.java

utf code with actual emojis for clarity, break onSlash handler into more helpers update helpthreadlistener to only store true participant count in database

adds helper function in HelpThreadLifecycleListener to get nonBot participant for database updates

Zabuzard · 2026-02-25T07:43:10Z

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadLifecycleListener.java

+        int messageCount = threadChannel.getMessageCount(); // TODO: to be replaced with participant
+                                                            // message count


dangling todo. will this be done in this PR or in another? consider maybe making a gh issue if latter

Zabuzard · 2026-02-25T07:48:49Z

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadStatsCommand.java

+        long secondsSinceLastUsage = getSecondsSinceLastUsage(channelId, now);
+        if (secondsSinceLastUsage != 0L) {


i dont quite get this. feels to me like ur abusing 0 as magic value to indicate something.

like, lets say i used the command 2 days ago, then a method named getSecondsSinceLastUsage should return me the seconds equivalent for 2 days and not 0.

consider renaming this to maybe getSecondsStillOnCooldown or something similar

Zabuzard · 2026-02-25T07:50:49Z

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadStatsCommand.java

+        double helpThreadInteractionRate = totalHelpThreadsCreated > 0
+                ? ((double) (totalHelpThreadsCreated - ghostThreads) / totalHelpThreadsCreated)
+                        * 100
+                : -1;


whats this? definitely needs a good name (or helper method) so this "formula" is easy to understand at first glance.

Zabuzard · 2026-02-25T07:52:15Z

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadStatsCommand.java

-                .where(HELP_THREADS.CREATED_AT.ge(startDate))
+                .where(HELP_THREADS.CREATED_AT.ge(statsDurationStartDate))
                .fetchOne();

            if (statsRecord == null || statsRecord.get(TOTAL_CREATED_FIELD, Integer.class) == 0) {
-                event.getHook()
-                    .editOriginal("No stats available for the last " + days + " days.")
-                    .queue();
-                return null;
+                return Optional.empty();


im pretty sure there is some variant of that fetchOne() that also returns an Optional already. in which case the code below could be simplified by using the optional-api instead

vishv843 and others added 3 commits August 29, 2024 15:29

added help stats command

8e1ae7d

Merge branch 'develop' into feat/help-thread-stats

3962878

refactor: help-stats slash command

a1e9ab5

replaces fetching metrics directly from database instead of discord, uses embed for showcases stats and making duration as optional choice in terms of days

ankitsmt211 self-assigned this Dec 21, 2025

ankitsmt211 requested a review from a team as a code owner December 21, 2025 10:59

ankitsmt211 added 3 commits December 21, 2025 16:38

chore: spotless fix

70fafef

refactor: helper for duration in seconds calculation

31f4190

spotless fixes, helper for calculating duration in seconds between datetime fields to be more compliant with code quality tests

refactor: emojis and whitespace constants

d9aec8f

change emojis to unicode character constants with descriptive names, single/blank line of space to be more intentional and clear

tj-wazei requested changes Dec 30, 2025

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/features/Features.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadStatsCommand.java Outdated Show resolved Hide resolved

refactor: remove star imports

ea88b0a

SquidXTV requested changes Jan 5, 2026

View reviewed changes

ankitsmt211 and others added 2 commits January 5, 2026 22:02

Update application/src/main/java/org/togetherjava/tjbot/features/help…

5cc8a3d

…/HelpThreadStatsCommand.java use a more simpler way to get days and a fallback if user entered option is missing Co-authored-by: Connor Schweighöfer <squidxtv@gmail.com>

chore: fix missing import

0651084

ankitsmt211 requested review from SquidXTV and tj-wazei January 5, 2026 16:35

ankitsmt211 added 2 commits January 5, 2026 22:31

fix: ghost thread count query

c3a01d7

since when saving thread meta data, participant count excludes author which means thread with 0 participants should be counted as ghost threads instead of single participant

feat: add cooldown per channel

7bf55b2

to avoid users from spamming, this adds a cooldown period of a min per channel

SquidXTV requested changes Jan 5, 2026

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadStatsCommand.java Outdated Show resolved Hide resolved

refactor: use Duration on cache write

e18e616

uses Duration instance for expiration of cache items instead of seperate values for ease of maintenance and clarity

SquidXTV previously approved these changes Jan 5, 2026

View reviewed changes

Zabuzard requested changes Jan 7, 2026

View reviewed changes

refactor: helpthreadstats and helpthreadlistener

1a17607

utf code with actual emojis for clarity, break onSlash handler into more helpers update helpthreadlistener to only store true participant count in database

ankitsmt211 dismissed SquidXTV’s stale review via 1a17607 February 8, 2026 01:45

ankitsmt211 added 3 commits February 8, 2026 07:26

refactor: add helper for getting nonbotuser

4c75144

adds helper function in HelpThreadLifecycleListener to get nonBot participant for database updates

Merge develop into feat/help-thread-stats

b089ae3

Merge branch 'develop' into feat/help-thread-stats

b21b82c

Zabuzard requested changes Feb 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feat/help thread stats#1361

Feat/help thread stats#1361
ankitsmt211 wants to merge 16 commits intoTogether-Java:developfrom
ankitsmt211:feat/help-thread-stats

ankitsmt211 commented Dec 21, 2025 •

edited

Loading

Uh oh!

tj-wazei left a comment

Uh oh!

Uh oh!

Uh oh!

SquidXTV left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Zabuzard Feb 25, 2026

Uh oh!

Zabuzard Feb 25, 2026

Uh oh!

Zabuzard Feb 25, 2026

Uh oh!

Zabuzard Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		int messageCount = threadChannel.getMessageCount(); // TODO: to be replaced with participant
		// message count

		long secondsSinceLastUsage = getSecondsSinceLastUsage(channelId, now);
		if (secondsSinceLastUsage != 0L) {

Uh oh!

Conversation

ankitsmt211 commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tj-wazei left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SquidXTV left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Zabuzard Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Zabuzard Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Zabuzard Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Zabuzard Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ankitsmt211 commented Dec 21, 2025 •

edited

Loading