Ongoing columnar work#704
Merged
frankmcsherry merged 3 commits intoTimelyDataflow:master-nextfrom Mar 29, 2026
Merged
Conversation
frankmcsherry
force-pushed
the
columnar_work
branch
from
39bf043 to
a7e92f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds up the scaffolding for what may be a better columnar container. It's quite a lot of typing, and does need to be reduced back down once it is dialed in. For the moment, treating the
columnar_support.rsfile as a bit of a work in progress, without production norms.The current effort is a both correct, and not badly architected
Mergerimplementation, based on trie merging. Lots of implementation defects, mostly around performance (and clarity). But I think this is a good skeleton to start from, and repeatedly dial in the performance of.