Add hamiltonian functions - #15012
Open
TejaashriUK wants to merge 2 commits into
Open
Conversation
daltino
reviewed
Aug 11, 2026
daltino
left a comment
There was a problem hiding this comment.
Looks like a solid addition overall — Hamiltonian mechanics is a meaningful contribution and the docstring explanation of both classical and quantum cases is a nice touch. Would love to see the full patch to verify, but make sure there are doctest examples in every function (required by the repo's guidelines) and that numpy is already a listed dependency. Also double-check that there's no overlap with any existing physics modules in the repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13235
Describe your change:
This PR adds
physics/hamiltonian.py, which implements two functions requested in #13235:classical_hamiltonian(mass, velocity, potential_energy)— computes the classical HamiltonianH = T + V, where kinetic energyT = 0.5 * m * v^2.quantum_hamiltonian(num_points, potential, mass, hbar, dx)— constructs the Hamiltonian matrix for a particle in a 1D potential using finite-difference discretization of the time-independent Schrödinger equation.Checklist: