rsz: Rename SizeDownMove to SizeDownFanoutMove#10433
Conversation
Signed-off-by: Eren Dogan <erendogan@google.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames the "SizeDown" optimization move to "ReduceLoad" throughout the rsz package. The changes encompass file renames, documentation updates, modifications to core C++ logic, and adjustments to the Tcl/Python interfaces and test suite. The review feedback identifies several internal log and debug messages that still use the old terminology and provides code suggestions to update them for consistency with the new naming convention.
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eren Dogan <erendogan@google.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
There are a variety of ways to reduce load. Split load is reducing load for example. DownsizeFanout would be more specific. |
|
Then, I think SizeDownFanout will be better (to match SizeUp moves' names). I will update this PR accordingly. |
Signed-off-by: Eren Dogan <erendogan@google.com>
erendn
changed the title
|
clang-tidy review says "All clean, LGTM! 👍" |
2 participants
Summary
Renames SizeDownMove to avoid confusion. There should still also be a SizeDownMove implementation but it should only down size the driver gate, not its fanout.
Type of Change
Impact
The PR shouldn't change any behavior.
Verification
./etc/Build.sh).