Skip to content

fixed verific check error #4216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sfmth wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

fixed verific check error #4216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build_openroad.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ __docker_build()
sed -i '/flow\/platforms/d' .dockerignore
fi
options=""
if [ -n "${WITH_VERIFIC}" ]; then
if [ ${WITH_VERIFIC} -eq 1 ]; then
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved robustness, it's recommended to use [[...]] for tests, quote variables, and use string comparison for flags. This prevents potential issues like word splitting or errors if the variable is not a valid integer. Using [[...]] is also more consistent with other conditional checks in this script (e.g., on line 194).

Suggested change
if [ ${WITH_VERIFIC} -eq 1 ]; then
if [[ "${WITH_VERIFIC}" == "1" ]]; then

cp -r "${VERIFIC_SRC}" tools/verific
options="-buildArgs=--build-arg verificPath=tools/verific"
fi
Expand Down