fix: support combined FileSystemTypes flags in Notify and Intercept - #1068
Merged
Conversation
…ept` `ChangeDescriptionExtensions.Matches` had the `HasFlag` operands swapped: it asked whether the changed entry's single `FileSystemType` contained the filter, instead of whether the filter contained the entry's type. Because `ChangeDescription.FileSystemType` always carries exactly one flag, a subscription for `FileSystemTypes.DirectoryOrFile` (or `Directory | File`) never matched any event and silently received nothing. Affects `OnChanged`, `OnCreated` and `OnDeleted` on both the notification and the interception handler. `changeType` is now compared with `HasFlag` as well, so both flags enumerations follow the same any-of semantics that the XML docs describe. --- - *Fixes #1067*
vbreuss
force-pushed
the
fix/1067-notify-multiple-filesystem-types
branch
from
August 7, 2026 16:48
56e1236 to
252a54c
Compare
|
Test Results 122 files ± 0 122 suites ±0 2h 25m 49s ⏱️ - 11m 19s Results for commit 252a54c. ± Comparison against base commit 3c8f5e1. This pull request removes 110396 and adds 110479 tests. Note that renamed tests count towards both.This pull request removes 12646 skipped tests and adds 12646 skipped tests. Note that renamed tests count towards both. |
|
This is addressed in release v7.0.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChangeDescriptionExtensions.Matcheshad theHasFlagoperands swapped: it asked whether the changed entry's singleFileSystemTypecontained the filter, instead of whether the filter contained the entry's type. BecauseChangeDescription.FileSystemTypealways carries exactly one flag, a subscription forFileSystemTypes.DirectoryOrFile(orDirectory | File) never matched any event and silently received nothing.Affects
OnChanged,OnCreatedandOnDeletedon both the notification and the interception handler.changeTypeis now compared withHasFlagas well, so both flags enumerations follow the same any-of semantics that the XML docs describe.