Skip to content

chore: v2 - update top menu in editor#2207

Merged
maxy-shpfy merged 1 commit intomasterfrom
05-04-chore_v2_-_update_top_menu_in_editor
May 6, 2026
Merged

chore: v2 - update top menu in editor#2207
maxy-shpfy merged 1 commit intomasterfrom
05-04-chore_v2_-_update_top_menu_in_editor

Conversation

@maxy-shpfy
Copy link
Copy Markdown
Collaborator

@maxy-shpfy maxy-shpfy commented May 5, 2026

Description

Closes https://github.com/Shopify/oasis-frontend/issues/606

Closes https://github.com/Shopify/oasis-frontend/issues/614

Removes the "Notes" menu button from the editor menu bar and replaces the ComponentsLibraryMenu's window-based navigation with route-based navigation using useNavigate. The "Explore library" option now navigates to APP_ROUTES.DASHBOARD_COMPONENTS instead of restoring a floating window, and the "My components" menu item has been removed entirely.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Open the editor and verify the "Notes" button no longer appears in the menu bar.
  2. Open the "Components Library" menu and confirm only "Explore library" and the import option are present.
  3. Click "Explore library" and verify it navigates to the dashboard components route instead of opening a floating window.

Additional Comments

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

🎩 Preview

A preview build has been created at: 05-04-chore_v2_-_update_top_menu_in_editor/0d1d3e4

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@maxy-shpfy maxy-shpfy marked this pull request as ready for review May 5, 2026 04:57
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner May 5, 2026 04:57
Copy link
Copy Markdown
Collaborator Author

maxy-shpfy commented May 6, 2026

Merge activity

  • May 6, 12:06 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 6, 12:07 AM UTC: Graphite rebased this pull request as part of a merge.
  • May 6, 12:09 AM UTC: Graphite rebased this pull request as part of a merge.
  • May 6, 12:12 AM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy maxy-shpfy force-pushed the 05-04-chore_v2_-_update_top_menu_in_editor branch from ea1c6a7 to bf13be0 Compare May 6, 2026 00:06
@maxy-shpfy maxy-shpfy force-pushed the 05-04-chore_v2_-_update_top_menu_in_editor branch from bf13be0 to 0d1d3e4 Compare May 6, 2026 00:09
@maxy-shpfy maxy-shpfy merged commit 9234bcb into master May 6, 2026
17 checks passed
@maxy-shpfy maxy-shpfy deleted the 05-04-chore_v2_-_update_top_menu_in_editor branch May 6, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants