Skip to content

fix: Stale Hydration Cache when Replacing Components#1926

Merged
camielvs merged 1 commit intomasterfrom
03-10-fix_stale_hydration_cache_when_replacing_components
Mar 12, 2026
Merged

fix: Stale Hydration Cache when Replacing Components#1926
camielvs merged 1 commit intomasterfrom
03-10-fix_stale_hydration_cache_when_replacing_components

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Mar 11, 2026

Description

Fixes a bug in the import/replace flow where new components may try to access the old component's hydration query cache, or a previously outdated version.

The issue has been fixed by explicitly resetting the query cache when adding a component to the library.

Related Issue and Pull requests

Closes #1921

Type of Change

  • Bug fix

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Add a component to canvas.
  2. Edit component definition
  3. Update the component without changing its name
  4. Save & replace the existing component definition
  5. Add the new component to canvas
  6. Edit/view the new component yaml and confirm it is the updated version

Additional Comments

Also added a missing await statement.

@github-actions
Copy link

github-actions bot commented Mar 11, 2026

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=03-10-fix_stale_hydration_cache_when_replacing_components/c2db281`

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camielvs camielvs marked this pull request as ready for review March 11, 2026 00:55
@camielvs camielvs requested a review from a team as a code owner March 11, 2026 00:55
Copy link
Collaborator Author

camielvs commented Mar 12, 2026

Merge activity

  • Mar 12, 12:50 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 12, 12:51 AM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 12, 12:53 AM UTC: @camielvs merged this pull request with Graphite.

@camielvs camielvs force-pushed the 03-10-fix_stale_hydration_cache_when_replacing_components branch from eddeb6f to c2db281 Compare March 12, 2026 00:50
@camielvs camielvs merged commit 51308f4 into master Mar 12, 2026
17 checks passed
@camielvs camielvs deleted the 03-10-fix_stale_hydration_cache_when_replacing_components branch March 12, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Component digests must always be re-calculated from text

2 participants