Skip to content

chore: Generalize setRunNameTemplate#1719

Merged
camielvs merged 1 commit intomasterfrom
01-28-chore_generalize_setrunnametemplate
Feb 5, 2026
Merged

chore: Generalize setRunNameTemplate#1719
camielvs merged 1 commit intomasterfrom
01-28-chore_generalize_setrunnametemplate

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Jan 29, 2026

Description

Generalize setRunNameTemplate so it can be used for updating any annotation on the component spec

Related Issue and Pull requests

Type of Change

  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

no change to ui

Test Instructions

confirm name templates and pipeline notes still work

Additional Comments

@camielvs camielvs mentioned this pull request Jan 29, 2026
3 tasks
Copy link
Collaborator Author

camielvs commented Jan 29, 2026

@camielvs camielvs mentioned this pull request Jan 29, 2026
3 tasks
@camielvs camielvs marked this pull request as ready for review January 29, 2026 00:31
@camielvs camielvs requested a review from a team as a code owner January 29, 2026 00:31
@camielvs camielvs force-pushed the 01-26-feat_user_notes_on_runs branch from af329da to a3c6427 Compare February 3, 2026 20:30
@camielvs camielvs force-pushed the 01-28-chore_generalize_setrunnametemplate branch from 9a3d3da to ec6245c Compare February 3, 2026 20:30
Copy link
Collaborator

@maxy-shpfy maxy-shpfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Will test on staging

@camielvs camielvs force-pushed the 01-28-chore_generalize_setrunnametemplate branch from ec6245c to 9813113 Compare February 5, 2026 21:25
@camielvs camielvs force-pushed the 01-26-feat_user_notes_on_runs branch 3 times, most recently from 25c6200 to bac19b2 Compare February 5, 2026 21:46
@camielvs camielvs force-pushed the 01-28-chore_generalize_setrunnametemplate branch from 9813113 to 23e9fd1 Compare February 5, 2026 21:46
@camielvs camielvs changed the base branch from 01-26-feat_user_notes_on_runs to graphite-base/1719 February 5, 2026 21:48
@camielvs camielvs force-pushed the 01-28-chore_generalize_setrunnametemplate branch from 23e9fd1 to 0131cf2 Compare February 5, 2026 21:49
@graphite-app graphite-app bot changed the base branch from graphite-base/1719 to master February 5, 2026 21:49
@camielvs camielvs force-pushed the 01-28-chore_generalize_setrunnametemplate branch from 0131cf2 to 03699dc Compare February 5, 2026 21:49
Copy link
Collaborator Author

camielvs commented Feb 5, 2026

Merge activity

  • Feb 5, 9:57 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 5, 9:57 PM UTC: @camielvs merged this pull request with Graphite.

@camielvs camielvs merged commit 5113bf3 into master Feb 5, 2026
7 of 8 checks passed
@camielvs camielvs deleted the 01-28-chore_generalize_setrunnametemplate branch February 5, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants