Skip to content

Add created by me filter#1713

Merged
Mbeaulne merged 1 commit intomasterfrom
01-27-add_created_by_me_filter
Feb 26, 2026
Merged

Add created by me filter#1713
Mbeaulne merged 1 commit intomasterfrom
01-27-add_created_by_me_filter

Conversation

@Mbeaulne
Copy link
Collaborator

@Mbeaulne Mbeaulne commented Jan 27, 2026

Description

Added a new CreatedByFilter component that allows filtering content by creator. The component includes:

  • A toggle switch for "Created by me" functionality
  • A search input for filtering by specific usernames
  • Comprehensive test coverage for all component behaviors

NOTE: This feature does get changed down the stack to a better UI/UX in my opinion.

Type of Change

  • New feature
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

The component renders a toggle switch with "Created by me" label and a search input with a search button

Test Instructions

  1. Toggle the switch to filter by current user
  2. Enter a username in the search field and click "Search" to filter by specific user
  3. Verify the component correctly displays the current filter state

Additional Comments

The component supports two main use cases:

  • Quick filtering by current user with the toggle
  • Specific user filtering with the search input
  • The value can be undefined (no filter), "me" (current user), or any username

Copy link
Collaborator Author

Mbeaulne commented Jan 27, 2026

@Mbeaulne Mbeaulne changed the base branch from 01-27-status_filter to graphite-base/1713 January 27, 2026 18:49
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from ec26c4a to e23f4b0 Compare January 27, 2026 18:49
@Mbeaulne Mbeaulne changed the base branch from graphite-base/1713 to 01-27-filter_bar January 27, 2026 18:50
@Mbeaulne Mbeaulne changed the base branch from 01-27-filter_bar to graphite-base/1713 January 27, 2026 18:51
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from e23f4b0 to 28071c7 Compare January 27, 2026 18:52
@Mbeaulne Mbeaulne changed the base branch from graphite-base/1713 to 01-27-status_filter January 27, 2026 18:52
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from 28071c7 to d1ebf96 Compare January 27, 2026 18:57
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch 2 times, most recently from 5e51976 to c6a465d Compare January 28, 2026 20:46
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from d1ebf96 to 08c0320 Compare January 28, 2026 20:46
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch from c6a465d to 97c09af Compare February 2, 2026 19:32
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from 08c0320 to d3185c3 Compare February 2, 2026 19:32
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch from 97c09af to b85a348 Compare February 2, 2026 19:33
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from d3185c3 to 5b0bea0 Compare February 2, 2026 19:33
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch from b85a348 to bd92e2d Compare February 2, 2026 20:31
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from 5b0bea0 to 36a4057 Compare February 2, 2026 20:31
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch from bd92e2d to b9286f8 Compare February 2, 2026 20:46
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from 36a4057 to 766de30 Compare February 2, 2026 20:46
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch from 23fc8a7 to 8d91f5a Compare February 3, 2026 17:56
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from 3660328 to 833979e Compare February 3, 2026 17:56
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch from 8d91f5a to c562c87 Compare February 3, 2026 18:03
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch 2 times, most recently from 98b72a4 to abc9a53 Compare February 9, 2026 17:11
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch from c562c87 to 7f1f58c Compare February 9, 2026 17:11
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from abc9a53 to 0d2db54 Compare February 9, 2026 17:37
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch 2 times, most recently from 1edb04b to a76d8c3 Compare February 9, 2026 17:44
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from 0d2db54 to 0443109 Compare February 9, 2026 17:44
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch from a76d8c3 to ec25023 Compare February 9, 2026 17:55
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from 0443109 to 8c73abc Compare February 9, 2026 17:55
@Mbeaulne Mbeaulne marked this pull request as ready for review February 9, 2026 18:04
@Mbeaulne Mbeaulne requested a review from a team as a code owner February 9, 2026 18:04
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch 2 times, most recently from ed20d9c to d0c1d85 Compare February 9, 2026 19:37
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch 2 times, most recently from baef097 to e1e9de5 Compare February 9, 2026 19:51
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from d0c1d85 to 5b84513 Compare February 9, 2026 19:51
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch from e1e9de5 to 4639b7e Compare February 9, 2026 20:50
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch 2 times, most recently from 7111700 to 2558d71 Compare February 9, 2026 20:56
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch 2 times, most recently from 2441f6b to f0bf8ba Compare February 10, 2026 15:04
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from 2558d71 to c463ef7 Compare February 10, 2026 15:05
if (checked) {
// Enable filter - if no specific user set, default to "me"
if (!value) {
onChange("me");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions:
How reliable is this "me". Is this really the value we use in our API to represent the current user?

Is there an existing constant we can use?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect to be filtering by an email, or unique id, instead of me

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can filter by email address (e.g. if an email is typed into the search box), but my understanding is that the "filter by me" toggle literally sends the value "me" to the backend.

Copy link
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might as well get this moving & iterate later when we have the api

Copy link
Collaborator Author

Mbeaulne commented Feb 26, 2026

Merge activity

  • Feb 26, 3:20 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 26, 3:21 PM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 26, 3:23 PM UTC: @Mbeaulne merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants