chore: update nitro version#7548
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
✅ Files skipped from review due to trivial changes (8)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughExample and e2e package.json manifests update the nitro dependency to ^3.0.260603-beta; examples/react/start-rscs replaces the nightly alias resolver with the semver constraint. ChangesNitro beta version alignment
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 8f4e7a2
☁️ Nx Cloud last updated this comment at |
ulrichstark
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@examples/solid/start-basic/package.json`:
- Line 23: The pnpm lockfile still lists the old specifier for the dependency
"nitro" while package.json now requires "^3.0.260603-beta"; regenerate and
commit an updated pnpm-lock.yaml so the lock matches the "nitro" specifier in
examples' package.json (run pnpm install at repo root or in the examples
workspace to update the lockfile, verify the "nitro" entry now shows
^3.0.260603-beta, and commit the changed pnpm-lock.yaml).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6f2c24d8-afc7-4b94-8d5a-f165650e3daa
📒 Files selected for processing (4)
examples/react/start-basic/package.jsonexamples/react/start-rscs/package.jsonexamples/solid/start-basic-nitro/package.jsonexamples/solid/start-basic/package.json
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud is proposing a fix for your failed CI:
We add waitForFunction(() => window.SCRIPT_1 === true) before the assertion in the "client side navigating to a route with scripts" test to fix the race condition where the dynamically injected script.js had not yet executed when the test checked window.SCRIPT_1. The nitro version bump (3.0.260311-beta → 3.0.260603-beta) changed the timing of script injection during client-side navigation, causing the synchronous assertion to see undefined instead of true.
Warning
❌ We could not verify this fix.
diff --git a/e2e/solid-start/basic/tests/navigation.spec.ts b/e2e/solid-start/basic/tests/navigation.spec.ts
index ed0b0d3a..68cb56e1 100644
--- a/e2e/solid-start/basic/tests/navigation.spec.ts
+++ b/e2e/solid-start/basic/tests/navigation.spec.ts
@@ -50,6 +50,7 @@ test('client side navigating to a route with scripts', async ({ page }) => {
await page.waitForURL('/')
await page.getByRole('link', { name: 'Scripts', exact: true }).click()
await expect(page.getByTestId('scripts-test-heading')).toBeInViewport()
+ await page.waitForFunction(() => (window as any).SCRIPT_1 === true)
expect(await page.evaluate('window.SCRIPT_1')).toBe(true)
expect(await page.evaluate('window.SCRIPT_2')).toBe(undefined)
})
Because this branch comes from a fork, it is not possible for us to apply fixes directly, but you can apply the changes locally using the available options below.
Apply changes locally with:
npx nx-cloud apply-locally E1dG-DtsY
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
schiller-manuel
force-pushed
the
chore(examples)--update-nitro-version
branch
from
aecc803 to
8f4e7a2
Compare
|
The CI failure is unrelated and not caused by this change or my recent changes, or? |
1 participant
Version of the nitro package was almost three months old in some example projects.
Edit: I also decided to update the other nitro dependencies in /e2e to the same version to deduplicate dependencies. Close to 900 lines saved in pnpm-lock.yaml 🥳
Summary by CodeRabbit