Skip to content

Comments

perf: revert to Response, and add docs regarding for FastResponse#6618

Merged
birkskyum merged 4 commits intomainfrom
use-response
Feb 9, 2026
Merged

perf: revert to Response, and add docs regarding for FastResponse#6618
birkskyum merged 4 commits intomainfrom
use-response

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Feb 9, 2026

Reverts:

Adds docs about FastResponse instead

Summary by CodeRabbit

  • Documentation

    • Added a "FastResponse" performance tip for Node.js + Nitro hosting in React and Solid guides, noting an expected ~5% throughput improvement and usage steps.
  • Refactor

    • Router packages now emit standard Response objects for server-side rendering.
    • Removed transitive srvx dependency from React, Solid, and Vue router packages.

@nx-cloud
Copy link

nx-cloud bot commented Feb 9, 2026

View your CI Pipeline Execution ↗ for commit abc5ca6

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-09 06:38:15 UTC

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026

📝 Walkthrough

Walkthrough

This PR removes the srvx dependency and replaces FastResponse usage with native Response across React, Solid, and Vue router SSR implementations, and adds documentation tips about using FastResponse for Node.js/Nitro hosting scenarios.

Changes

Cohort / File(s) Summary
Documentation
docs/start/framework/react/guide/hosting.md, docs/start/framework/solid/guide/hosting.md
Added "Performance Tip: FastResponse" guidance and code snippets describing srvx's FastResponse usage for Node.js/Nitro hosting (notes applicability and ~5% throughput improvement).
Package Dependencies
packages/react-router/package.json, packages/solid-router/package.json, packages/vue-router/package.json
Removed the srvx dependency from each router package's package.json.
SSR Response Construction
packages/react-router/src/ssr/renderRouterToStream.tsx, packages/solid-router/src/ssr/renderRouterToStream.tsx, packages/vue-router/src/ssr/renderRouterToStream.tsx
Removed FastResponse imports and replaced constructions of new FastResponse(...) with new Response(...) in both bot and streaming code paths; status codes and headers preserved.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Poem

🐇 I hopped through bytes and code so bright,
I nudged a FastResponse into the light,
Then watched dependencies slip away,
Native Response now leads the play,
A little hop for cleaner day.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: reverting FastResponse usage back to standard Response and adding documentation about FastResponse as an optimization option.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch use-response

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@birkskyum birkskyum requested a review from Sheraff February 9, 2026 05:44
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 9, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@6618

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@6618

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@6618

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@6618

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@6618

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@6618

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@6618

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@6618

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@6618

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@6618

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@6618

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@6618

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@6618

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@6618

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@6618

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@6618

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@6618

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@6618

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@6618

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@6618

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@6618

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@6618

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@6618

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@6618

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@6618

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@6618

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-fn-stubs@6618

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@6618

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@6618

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@6618

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@6618

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@6618

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@6618

@tanstack/vue-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router@6618

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-devtools@6618

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-ssr-query@6618

@tanstack/vue-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start@6618

@tanstack/vue-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-client@6618

@tanstack/vue-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-server@6618

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@6618

commit: abc5ca6

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@docs/start/framework/react/guide/hosting.md`:
- Around line 239-248: Add an explicit install instruction for srvx before the
FastResponse snippet: note that srvx is no longer a transitive dependency and
show the user to install it (e.g., npm/yarn/pnpm install srvx) prior to
importing FastResponse, and ensure the docs mention FastResponse and
globalThis.Response so readers know to run the install step before adding the
import and assignment.

@birkskyum birkskyum merged commit 641720f into main Feb 9, 2026
6 checks passed
@birkskyum birkskyum deleted the use-response branch February 9, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants