Skip to content
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/clear-filter-button.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/query-devtools': minor
---

Add clear button to filter input for improved UX. The button appears when the filter has text and clears the filter when clicked, automatically refocusing the input field. Works for both queries and mutations views.
50 changes: 50 additions & 0 deletions packages/query-devtools/src/Devtools.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -676,6 +676,7 @@ export const ContentView: Component<ContentViewProps> = (props) => {
setupQueryCacheSubscription()
setupMutationCacheSubscription()
let containerRef!: HTMLDivElement
let filterInputRef!: HTMLInputElement
const theme = useTheme()
const css = useQueryDevtoolsContext().shadowDOMTarget
? goober.css.bind({ target: useQueryDevtoolsContext().shadowDOMTarget })
Expand Down Expand Up @@ -907,6 +908,7 @@ export const ContentView: Component<ContentViewProps> = (props) => {
>
<Search />
<input
ref={filterInputRef}
aria-label="Filter queries by query key"
type="text"
placeholder="Filter"
Expand All @@ -925,6 +927,29 @@ export const ContentView: Component<ContentViewProps> = (props) => {
: props.localStore.mutationFilter || ''
}
/>
<Show
when={
selectedView() === 'queries'
? props.localStore.filter
: props.localStore.mutationFilter
}
>
<button
aria-label="Clear filter"
class={cx(styles().clearFilterBtn, 'tsqd-clear-filter-btn')}
onClick={() => {
if (selectedView() === 'queries') {
props.setLocalStore('filter', '')
} else {
props.setLocalStore('mutationFilter', '')
}
// Focus back to input after clearing
filterInputRef.focus()
Comment thread
lyzno1 marked this conversation as resolved.
}}
>
<XCircle />
</button>
</Show>
</div>
<div
class={cx(
Expand Down Expand Up @@ -3258,6 +3283,31 @@ const stylesFactory = (
outline: 2px solid ${colors.blue[800]};
}
`,
clearFilterBtn: css`
all: unset;
Comment thread
lyzno1 marked this conversation as resolved.
display: flex;
align-items: center;
justify-content: center;
cursor: pointer;
color: ${t(colors.gray[500], colors.gray[400])};
transition: color 0.2s ease;
flex-shrink: 0;

& > svg {
width: ${size[3]};
height: ${size[3]};
}

&:hover {
color: ${t(colors.gray[700], colors.gray[200])};
}

&:focus-visible {
outline: 2px solid ${colors.blue[800]};
outline-offset: 2px;
border-radius: ${border.radius.xs};
}
`,
filterSelect: css`
padding: ${tokens.size[0.5]} ${tokens.size[2]};
border-radius: ${tokens.border.radius.sm};
Expand Down