Merged
Conversation
983b164 to
dc65414
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@tanstack/hotkeys@0.3.1
Patch Changes
fix: handle dead keys in
matchesKeyboardEvent(#40)When
event.keyis'Dead'(length 4), the existingevent.codefallback—gated behindeventKey.length === 1—was never reached, causing hotkeys to silently fail.This most commonly affects macOS, where
Option+lettercombinations likeOption+E,Option+I,Option+U, andOption+Nproduce dead keys for accent composition. It also affects Windows and Linux users with international keyboard layouts (e.g., US-International, German, French) where certain key combinations produce dead keys.Added an early check: when
event.keynormalizes to'Dead', immediately fall back toevent.codeto extract the physical key via theKey*/Digit*prefixes. Punctuation dead keys (e.g.,'on US-International, whereevent.codeis'Quote') correctly returnfalsesince their codes don't match letter or digit patterns.@tanstack/hotkeys-devtools@0.3.1
Patch Changes
762cabf]:@tanstack/preact-hotkeys@0.3.1
Patch Changes
762cabf]:@tanstack/preact-hotkeys-devtools@0.3.1
Patch Changes
@tanstack/react-hotkeys@0.3.1
Patch Changes
762cabf]:@tanstack/react-hotkeys-devtools@0.3.1
Patch Changes
@tanstack/solid-hotkeys@0.3.1
Patch Changes
762cabf]:@tanstack/solid-hotkeys-devtools@0.3.1
Patch Changes