devtools move production exports to dedicated subdirectory #1989
+50
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 10fc53e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 10fc53e
☁️ Nx Cloud last updated this comment at |
Contributor
|
This makes sense to me, can you add a change set to the PR? |
Moved production exports of devtools to a dedicated subdirectory.
Member
Author
|
@harry-whorlow should I apply these changes to the Solid devtools as well? |
Contributor
|
If you would that would be awesome! 🔥 |
Member
Author
|
@harry-whorlow this is good to go 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes to the code paths for the production exports of
@tanstack/react-form-devtoolsand@tanstack/solid-form-devtools.The previous implementation had the
productionexports sourcing the Form Devtools Panel component from thedevelopmentimport. This meant that on build of your app, the production export would work, without erroring-out, but when running it in the browser, the Devtools Panel for Form would just be empty/null.Closes #1986
🎯 Changes
✅ Checklist
pnpm test:pr.🚀 Release Impact