Skip to content

fix(examples): align @tanstack/devtools-a11y version to fix sherif CI#474

Merged
AlemTuzlak merged 1 commit into
mainfrom
fix/sherif-a11y-version
Jun 23, 2026
Merged

fix(examples): align @tanstack/devtools-a11y version to fix sherif CI#474
AlemTuzlak merged 1 commit into
mainfrom
fix/sherif-a11y-version

Conversation

@AlemTuzlak

@AlemTuzlak AlemTuzlak commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Problem

CI on main is failing at the test:sherif step:

⨯ error Dependency @tanstack/devtools-a11y has multiple versions defined in the workspace. multiple-dependency-versions
    examples/react/a11y-devtools     ^0.1.5  ↑ highest
    examples/angular/a11y-devtools    ^0.1.4  ↓ lowest

The Version Packages release bumped the react a11y example to ^0.1.5 but left the angular example at ^0.1.4, so sherif's multiple-dependency-versions rule fails.

Fix

Bump @tanstack/devtools-a11y to ^0.1.5 in the angular a11y example (and the matching lockfile specifier) so both examples use the same version.

sherif now passes locally:

✓ No issues found

Summary by CodeRabbit

  • Chores
    • Updated accessibility devtools dependency to the latest patch version.

The Version Packages release bumped the react a11y example to ^0.1.5
but left the angular example at ^0.1.4, tripping sherif's
multiple-dependency-versions check and failing CI on main.
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6492563c-667d-4e73-89a0-0820022e7476

📥 Commits

Reviewing files that changed from the base of the PR and between da1d7e2 and 8647903.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • examples/angular/a11y-devtools/package.json

📝 Walkthrough

Walkthrough

The @tanstack/devtools-a11y dependency in examples/angular/a11y-devtools/package.json is bumped from ^0.1.4 to ^0.1.5. No other files or fields are changed.

Changes

Dependency Version Bump

Layer / File(s) Summary
Update @tanstack/devtools-a11y to ^0.1.5
examples/angular/a11y-devtools/package.json
Version constraint for @tanstack/devtools-a11y changed from ^0.1.4 to ^0.1.5.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Poem

A tiny hop, a version leap,
From .4 to .5 — not steep.
The rabbit checks the package file,
One line changed with a smile.
🐇 ✨ All is well, deploy in style!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description provides context, explains the problem, describes the fix, and verifies it works locally; however, it lacks required checklist items and release impact declaration. Add the complete checklist section with items checked or unchecked, and specify whether this change requires a changeset or is dev-only under 'Release Impact'.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(examples): align @tanstack/devtools-a11y version to fix sherif CI' clearly and specifically describes the main change: aligning a dependency version across examples to fix CI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sherif-a11y-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jun 23, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 8647903

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 13s View ↗
nx run-many --targets=build --exclude=examples/** ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2026-06-23 09:22:36 UTC

@pkg-pr-new

pkg-pr-new Bot commented Jun 23, 2026

Copy link
Copy Markdown
More templates

@tanstack/angular-devtools

npm i https://pkg.pr.new/@tanstack/angular-devtools@474

@tanstack/devtools

npm i https://pkg.pr.new/@tanstack/devtools@474

@tanstack/devtools-a11y

npm i https://pkg.pr.new/@tanstack/devtools-a11y@474

@tanstack/devtools-client

npm i https://pkg.pr.new/@tanstack/devtools-client@474

@tanstack/devtools-ui

npm i https://pkg.pr.new/@tanstack/devtools-ui@474

@tanstack/devtools-utils

npm i https://pkg.pr.new/@tanstack/devtools-utils@474

@tanstack/devtools-vite

npm i https://pkg.pr.new/@tanstack/devtools-vite@474

@tanstack/devtools-event-bus

npm i https://pkg.pr.new/@tanstack/devtools-event-bus@474

@tanstack/devtools-event-client

npm i https://pkg.pr.new/@tanstack/devtools-event-client@474

@tanstack/preact-devtools

npm i https://pkg.pr.new/@tanstack/preact-devtools@474

@tanstack/react-devtools

npm i https://pkg.pr.new/@tanstack/react-devtools@474

@tanstack/solid-devtools

npm i https://pkg.pr.new/@tanstack/solid-devtools@474

@tanstack/svelte-devtools

npm i https://pkg.pr.new/@tanstack/svelte-devtools@474

@tanstack/vue-devtools

npm i https://pkg.pr.new/@tanstack/vue-devtools@474

commit: 8647903

@AlemTuzlak AlemTuzlak merged commit b1c1b20 into main Jun 23, 2026
10 checks passed
@AlemTuzlak AlemTuzlak deleted the fix/sherif-a11y-version branch June 23, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant