fix: resolve legacy redirects on client-side navigation - #824
Draft
devin-ai-integration[bot] wants to merge 1 commit into
Draft
fix: resolve legacy redirects on client-side navigation#824devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
The client-redirects plugin only emits static redirect pages, which are bypassed by SPA navigation (e.g. stale Algolia search results). Wrap NotFound/Content to resolve the same redirect rules client-side. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
|
Tested this end-to-end on the local dev server (
Minor edge case noted: an old |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Navigating to an old (redirected) URL through in-app navigation — e.g. selecting a stale Algolia search result like
/docs/theoplayer/how-to-guides/cast/chromecast/sending-messages-from-to-sender-to-from-receiver/— showed "Page Not Found", while a full page refresh worked. That's because@docusaurus/plugin-client-redirectsonly emits static redirect HTML pages, which SPA (client-side) navigation never loads.This adds a
NotFound/Contenttheme wrapper that resolves the same redirect rules client-side: when a route 404s, it looks the path up inredirectsMillicast.json/redirectsAds.json/redirectsTHEOPlayer.jsonplus the inverse of thecreateRedirectsrules fromdocusaurus.config.ts, and issues a router<Redirect>to the new path (preserving query and hash). Unknown paths still render the normal Not Found page.Note:
NotFound/Content(not the top-levelNotFoundpage) is wrapped because doc-path 404s are rendered through the docs plugin's fallback, which usesNotFound/Contentdirectly.Verified locally: old Chromecast guide URLs now land on the
web/cast/chromecast/...pages via SPA navigation, and a genuinely unknown URL still shows Page Not Found.Link to Devin session: https://dolby.devinenterprise.com/sessions/3bdada042aef4c64b0f981ba4dc3a620