Create a MemoryDomain subclass which wraps IDebuggable.{GetCpuFlagsAndRegisters,SetCpuRegister}

[YoshiRulz]

[vadosnaprimer]

I like the concept. No idea about the code tho.

[SuuperW]

1. I think it would be better to not modify cores' code. It should be possible to conditionally add the registers domain outside of the core, depending on if it provides the required service.

2. I don't exactly like the inefficiencies here with reading and writing more than necessary, but I suppose there's not a lot you could realistically do about that.

3. I also see unchecked in a lot of places. Does this provide any benefit? Since unchecked is default, this seems like unneeded fluff.

[YoshiRulz]

1. I think it would be better to not modify cores' code. It should be possible to conditionally add the registers domain outside of the core, depending on if it provides the required service.

In BasicServiceProvider maybe? It can't be something the Hex Editor does internally if we want it to be usable from the APIs.

3. I also see unchecked in a lot of places. Does this provide any benefit? Since unchecked is default, this seems like unneeded fluff.

Enabling $(CheckForOverflowUnderflow) is one of my long-term cleanup goals.
Some casts in unchecked are equivalent to the same cast without it, not sure which, but if someone cared enough to make a list we could flag those with an Analyzer. I just have muscle memory to write unchecked((uint) n) instead of something clearer like Unsafe.As<int, uint>(ref n).