Experimenting with Fluent.Net (i18n) in DiscoHawk#4406
Draft
Experimenting with Fluent.Net (i18n) in DiscoHawk#4406
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Collaborator
That's true and fine, but it doesn't look like that's what you're doing in here. Is using fluent not possible while keeping the existing structure? |
Member
Author
|
To keep the Designer files, I would have to move every BizHawk/src/BizHawk.Client.EmuHawk/tools/Watch/RamWatch.cs Lines 41 to 88 in 56f3a2d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Fluent homepage and my notes #64.
edit: Marked as draft again because I wanted a POC for actually localising the app, but when I tried that I ran into some bugs in Mono that will have to be worked around, as well as some problems with the code I've written.
If someone on Windows could check the Designer inlining matches the previous layout, those can be pushed to master immediately.Will do later, in the meantime here's a cleaner diff view.