Update simdjson to 4.2.3 and introduce Builder API to do json encoding#31
Open
jimmystewpot wants to merge 7 commits intoSunDoge:masterfrom
Open
Update simdjson to 4.2.3 and introduce Builder API to do json encoding#31jimmystewpot wants to merge 7 commits intoSunDoge:masterfrom
jimmystewpot wants to merge 7 commits intoSunDoge:masterfrom
Conversation
Author
|
With further testing, we can confirm that #29 exists, and this appears to have been resolved by setting the lifetimes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been using the simdjson C++ library for some time. As we use more Rust, we have been looking at what the best option is for high-performance parsing of json. This library is one of the options we have evaluated.
In that evaluation, we bumped simdjson to 4.2.3 to implement the Builder interface, which is now part of the upstream C++ library. This introduces the ability to output json strings, so we can decode and encode with the same library easily.
Changes
&strinstead of&String, which reduces allocations slightlyI bumped the versions in the Cargo.toml files, however I am not sure what your version logic is, so I just took a guess.