Add go-to / copy current video position to the player slider#11625
Open
muaz978 wants to merge 1 commit into
Open
Add go-to / copy current video position to the player slider#11625muaz978 wants to merge 1 commit into
muaz978 wants to merge 1 commit into
Conversation
Right-clicking the video position slider now offers "Go to video position" (the existing ShowGoToVideoPosition dialog) and "Copy" (copies the current position as a timecode, applying the configured video offset). This restores the SE4 "Video position" control's ability to jump to and copy the current position, which had no UI entry point in SE5 - only a shortcut for go-to. - New CopyVideoPosition command in MainViewModel. - VideoPlayerControl exposes GoToPositionRequested/CopyPositionRequested events via a context menu on the position slider; InitVideoPlayer wires them to the view-model commands. Reuses existing language strings (no new tags).
Member
|
Hey, Muaz. The This is how I see it on most platforms, but it's up to @nikolajolsson to decide. Another option is to add a NumericUpDown with the video position at the bottom in the toolbar, but maybe it wouldn't fit or would look too crowded. |
Author
|
Hey dear, I can handle both, but let's see what @nikolajolsson say, and then I will act accordingly. |
Member
|
We can take a look after v5.0.0 :) |
Author
|
On your mark. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds go-to / copy of the current video position, addressing the follow-up on #11598 (@OmrSi: "a way to go to a video position and copy the current video position", which SE4 had on the Video position control).
Right-click the video position slider:
New
CopyVideoPositioncommand;VideoPlayerControlraisesGoToPositionRequested/CopyPositionRequestedfrom a context menu on the slider, wired to the view-model inInitVideoPlayer. Reuses existing language strings (no new tags). Builds clean (0/0).Couldn't GUI-test here; a Windows/macOS test build can be provided to confirm the menu and copy if useful.