Fix broken build netsdk 10.0.200, fix green builds on failure#1657
Merged
bart-vmware merged 8 commits intomainfrom Mar 12, 2026
Merged
Fix broken build netsdk 10.0.200, fix green builds on failure#1657bart-vmware merged 8 commits intomainfrom
bart-vmware merged 8 commits intomainfrom
Conversation
Fixes occurrences of the following errors: error IDE0370: Suppression is unnecessary (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0370)
1ec0859 to
208ab7d
Compare
This reverts commit 9ee4528.
c2eeaab to
2fa8000
Compare
|
Contributor
Summary - All Code Coverage (ubuntu-latest)
|
TimHess
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Problem
The
Steeltoe.All.ymlworkflow hadcontinue-on-error: trueat the job level, which told GitHub Actions to treat every job as successful regardless of outcome. This made the workflow appear green even when all jobs failed.Fix
Removed
continue-on-error: truefrom the job level. Test steps now fail naturally, showing a red X in the UI and putting the job in a failure state. Post-test steps useifconditions with!cancelled()(a status check function that prevents GitHub from prepending the implicitsuccess()check) to control whether they run after a failure.Changes
Steeltoe.All.yml: Removed job-levelcontinue-on-error: true. Addedidto test steps and!cancelled()-based conditions on post-test steps.component-shared-workflow.yml: Addedidto test steps and!cancelled()-based conditions on post-test steps (this file never had job-levelcontinue-on-error, but previously usedif: ${{ failure() }}andif: ${{ !cancelled() }}which didn't account for all scenarios).Scenarios
Manually verified (see commit history)
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.