Skip to content

Fix broken build netsdk 10.0.200, fix green builds on failure#1657

Merged
bart-vmware merged 8 commits intomainfrom
fix-broken-build-netsdk-10.0.200
Mar 12, 2026
Merged

Fix broken build netsdk 10.0.200, fix green builds on failure#1657
bart-vmware merged 8 commits intomainfrom
fix-broken-build-netsdk-10.0.200

Conversation

@bart-vmware
Copy link
Member

@bart-vmware bart-vmware commented Mar 11, 2026

Description

Problem

The Steeltoe.All.yml workflow had continue-on-error: true at the job level, which told GitHub Actions to treat every job as successful regardless of outcome. This made the workflow appear green even when all jobs failed.

Fix

Removed continue-on-error: true from the job level. Test steps now fail naturally, showing a red X in the UI and putting the job in a failure state. Post-test steps use if conditions with !cancelled() (a status check function that prevents GitHub from prepending the implicit success() check) to control whether they run after a failure.

Changes

  • Steeltoe.All.yml: Removed job-level continue-on-error: true. Added id to test steps and !cancelled()-based conditions on post-test steps.
  • component-shared-workflow.yml: Added id to test steps and !cancelled()-based conditions on post-test steps (this file never had job-level continue-on-error, but previously used if: ${{ failure() }} and if: ${{ !cancelled() }} which didn't account for all scenarios).

Scenarios

Scenario Upload dumps Report results Coverage Job result
Build fails skip skip skip red
Tests pass skip run run green
Tests fail run run skip red
Tests pass, reporter fails skip run (fails) skip red
Tests pass, coverage fails skip run run (fails) red
Cancelled skip skip skip cancelled

Manually verified (see commit history)

  • Test: build failure must abort the job and report outcome Red
  • Test: test failure must upload results and report outcome Red
  • Test: report failure must abort the job and report outcome Red
  • Test: cancel during build skips all subsequent steps
  • Test: cancel during test skips all subsequent steps

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

Fixes occurrences of the following errors:
error IDE0370: Suppression is unnecessary (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0370)
@bart-vmware bart-vmware force-pushed the fix-broken-build-netsdk-10.0.200 branch 3 times, most recently from 1ec0859 to 208ab7d Compare March 11, 2026 13:29
@bart-vmware bart-vmware force-pushed the fix-broken-build-netsdk-10.0.200 branch 2 times, most recently from c2eeaab to 2fa8000 Compare March 12, 2026 10:12
@bart-vmware bart-vmware changed the title Fix broken build netsdk 10.0.200 Fix broken build netsdk 10.0.200, fix green builds on failure Mar 12, 2026
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Summary - All Code Coverage (ubuntu-latest)

Line coverage Branch coverage

Assembly Line coverage Branch coverage
Steeltoe.Bootstrap.AutoConfiguration 97.4% 100%
Steeltoe.Common 84.3% 77.8%
Steeltoe.Common.Certificates 96.2% 85.5%
Steeltoe.Common.Hosting 84% 70%
Steeltoe.Common.Http 100% 85.2%
Steeltoe.Common.Logging 81.1% 56.2%
Steeltoe.Common.Net 64.5% 66.6%
Steeltoe.Configuration.Abstractions 98.6% 91.4%
Steeltoe.Configuration.CloudFoundry 99.1% 91.8%
Steeltoe.Configuration.ConfigServer 97.2% 91.6%
Steeltoe.Configuration.Encryption 97.6% 92.4%
Steeltoe.Configuration.Kubernetes.ServiceBindings 95.1% 89.3%
Steeltoe.Configuration.Placeholder 93.8% 84.7%
Steeltoe.Configuration.RandomValue 93.2% 90%
Steeltoe.Configuration.SpringBoot 98.3% 95%
Steeltoe.Connectors 93.9% 89.4%
Steeltoe.Connectors.EntityFrameworkCore 81.5% 75%
Steeltoe.Discovery.Configuration 92.3% 100%
Steeltoe.Discovery.Consul 97.6% 96.5%
Steeltoe.Discovery.Eureka 92.2% 85.3%
Steeltoe.Discovery.HttpClients 94.3% 95.4%
Steeltoe.Logging.Abstractions 99.4% 96.9%
Steeltoe.Logging.DynamicConsole 100% 95.4%
Steeltoe.Logging.DynamicSerilog 99.1% 95.4%
Steeltoe.Management.Abstractions 100% 100%
Steeltoe.Management.Endpoint 95.8% 89%
Steeltoe.Management.Prometheus 95.8% 91.6%
Steeltoe.Management.Tasks 100% ****
Steeltoe.Management.Tracing 100% 75%
Steeltoe.Security.Authentication.JwtBearer 100% 100%
Steeltoe.Security.Authentication.OpenIdConnect 73.8% 59%
Steeltoe.Security.Authorization.Certificate 96.7% 75%
Steeltoe.Security.DataProtection.Redis 100% ****

@bart-vmware bart-vmware marked this pull request as ready for review March 12, 2026 12:24
@bart-vmware bart-vmware requested a review from TimHess March 12, 2026 12:24
@bart-vmware bart-vmware merged commit 58a177b into main Mar 12, 2026
25 of 37 checks passed
@bart-vmware bart-vmware deleted the fix-broken-build-netsdk-10.0.200 branch March 12, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants