STAC-24297: add worked OpenTelemetry webshop example to the generic s…#6
STAC-24297: add worked OpenTelemetry webshop example to the generic s…#6aacevedoosorio wants to merge 3 commits into
Conversation
| ## Development Workflow | ||
|
|
||
| ### 1. Modify Your StackPack | ||
| ```bash |
There was a problem hiding this comment.
A useful command in the dev workflow is the test-deploy sub-command (it's still feature flagged, though).
There was a problem hiding this comment.
Good call — added test-deploy to the Development Workflow section, noting it's still behind STS_EXPERIMENTAL_STACKPACKS=true. It's been the workhorse for iterating this PR.
| projection: | ||
| _type: TagProjection | ||
| provisioning: | ||
| externalComponentSelector: "external.mapping.identifier == 'urn:stackpack:<< .Name >>:otel-component-mapping:database'" |
There was a problem hiding this comment.
Shouldn't the field be topologySourceSelector? https://github.com/StackVista/stackstate-openapi/blob/master/spec_domain/settings.yaml#L1200
There was a problem hiding this comment.
great catch, let me fix it.
There was a problem hiding this comment.
Fixed. And it was more than a rename — topologySourceSelector compiles the CEL in a different context, so the old external.mapping.identifier failed validation once renamed. The correct variable is source, so it's now source.mapping.identifier == '...' (matches the validator's HighlightProvisioningContext / the ComponentService test). Applied to cart, checkout and database.
| filter: | ||
| _type: "TagFilter" | ||
| tagKey: "service.namespace" | ||
| moreTab: "<< .DisplayName >>" |
There was a problem hiding this comment.
This looks like it should be menuSection: https://github.com/StackVista/stackstate-openapi/blob/master/spec_domain/settings.yaml#L1111
There was a problem hiding this comment.
Fixed — renamed moreTab -> menuSection in both database.sty and microservice.sty (matches the spec).
…, optional highlight fields - Rename moreTab -> menuSection and externalComponentSelector -> topologySourceSelector to match the settings OpenAPI spec; fix the provisioning CEL to use the `source` variable (source.mapping.identifier) - Drop the highlight `fields` block from cart (optional per spec; composes from the base) and remove the stale "fields is required" comment - Remove leftover topology.layer/domain references in header comments - Document the experimental `test-deploy` subcommand in the dev workflow
aacevedoosorio
force-pushed
the
stac-24297
branch
from
fee05f8 to
2f25612
Compare
3 participants
…caffold template