Skip to content

ci: enforce uv.lock consistency with --locked flag #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryoppippi merged 2 commits into from
Jan 22, 2026
+2 −2
Merged

ci: enforce uv.lock consistency with --locked flag #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b4b4ad
ci: enforce uv.lock consistency with --locked flag
ryoppippi Jan 22, 2026
2e545b5
Merge branch 'main' into ci/uv-sync-locked
ryoppippi Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup-nix/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ runs:
- name: Install Python dependencies
if: inputs.skip-uv-sync != 'true'
shell: bash
run: uv sync --all-extras
run: uv sync --all-extras --locked

- name: Install MCP mock server dependencies
if: inputs.skip-uv-sync != 'true'
Expand Down
2 changes: 1 addition & 1 deletion flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
# Install Python dependencies only if .venv is missing or uv.lock is newer
if [ ! -d .venv ] || [ uv.lock -nt .venv ]; then
echo "📦 Installing Python dependencies..."
uv sync --all-extras
uv sync --all-extras --locked
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --locked flag in the shellHook may prevent developers from entering the development shell if uv.lock is out of sync with pyproject.toml. This creates a problematic scenario where developers cannot enter the shell to fix the lockfile issue.

Consider removing --locked from the shellHook while keeping it in CI (setup-nix action). The shellHook is meant to facilitate local development setup, not enforce strict validation. CI will catch lockfile drift issues, while local developers can still sync their dependencies even when the lockfile needs updating.

Suggested change
uv sync --all-extras --locked
uv sync --all-extras

Copilot uses AI. Check for mistakes.
fi
# Install git hooks
Expand Down