Skip to content

Conversation

@ryoppippi
Copy link
Member

@ryoppippi ryoppippi commented Jan 22, 2026

Summary

  • Remove explicit nixfmt.package = pkgs.nixfmt-rfc-style override in treefmt config (now defaults to nixfmt)
  • Replace nixfmt-rfc-style with nixfmt in devShells.default
  • Update nix-workflow.md documentation to reflect the change

Test plan

  • nix flake check passes without deprecation warning

Summary by cubic

Switched from nixfmt-rfc-style to nixfmt across the flake to remove deprecation warnings and standardize formatting. Removed the treefmt nixfmt.package override (now defaults to nixfmt), updated devShells, and refreshed nix-workflow docs.

Written for commit b4823cd. Summary will update on new commits.

nixfmt-rfc-style is now the same as pkgs.nixfmt and should be used
instead. This removes the explicit package override in treefmt and
updates devShells to use the standard nixfmt package.

- Remove nixfmt.package override in treefmt config (defaults to nixfmt)
- Replace nixfmt-rfc-style with nixfmt in devShells.default
- Update nix-workflow.md documentation to reflect the change
Copilot AI review requested due to automatic review settings January 22, 2026 10:51
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Nix flake configuration to replace the deprecated nixfmt-rfc-style package with nixfmt, ensuring the project uses the current standard formatter.

Changes:

  • Removed explicit package override in treefmt configuration (defaults to nixfmt now)
  • Updated devShells.default to use nixfmt instead of nixfmt-rfc-style
  • Updated documentation to reflect the package name change

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
flake.nix Removed deprecated package override and updated development shell package reference
.claude/rules/nix-workflow.md Updated example code to show nixfmt instead of nixfmt-rfc-style

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ryoppippi ryoppippi merged commit 10627b4 into main Jan 22, 2026
23 checks passed
@ryoppippi ryoppippi deleted the fix/nixfmt-deprecation branch January 22, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants