fix(stacks-docs-next): conditional banner margin and dupe description fix#2237
Merged
dancormier merged 1 commit intomainfrom Apr 15, 2026
Merged
fix(stacks-docs-next): conditional banner margin and dupe description fix#2237dancormier merged 1 commit intomainfrom
dancormier merged 1 commit intomainfrom
Conversation
…tion - Apply mb128 below breadcrumb row only when a banner image is present; fall back to mb24 on pages without a banner - Remove duplicate description paragraph from flex.md content (it already exists in the frontmatter which the template renders in the page header) - Fix stray </p> at end of flex.md description frontmatter value Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dancormier
changed the title
abovedave
approved these changes
Apr 15, 2026
Collaborator
abovedave
left a comment
abovedave
left a comment
There was a problem hiding this comment.
Tested locally, looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mb128(128px) gap before the page title, which created an awkward large blank space. This is now conditional:mb128when a banner image is present,mb24otherwise.flex.mdhad its description text duplicated: once in the frontmatterdescription:field (rendered by the page template in the styled header area) and once as a standalone paragraph near the end of the file's content. The body duplicate is removed. Also fixes a stray</p>at the end of the frontmatter value.Related Issue
STACKS-843
Changes
packages/stacks-docs-nextsrc/routes/[category]/[[section]]/[subsection]/+page.svelte— makemb128on breadcrumb row conditional ondata?.active?.imagesrc/docs/public/system/base/flex.md— remove duplicate description paragraph from content body; fix stray</p>in frontmatterTesting
These are docs-only changes. Verify visually:
/brand/logo) should have the large gap between breadcrumbs and title as before/system/accessibility/intro) should have a smallermb24gap instead of the previousmb128/system/base/flexpage should not show the description text twice once legacy is removed