Introduce TeleportBehavior - #2614
Open
whimxiqal wants to merge 2 commits into
Open
Conversation
Author
|
I'm open to suggestions here. I've the API for the PortalLogic and its Builder to be a bit obtuse. The "composite" nature of what gets ultimately built makes it so as a consumer, I have to build a builder and then tell it to fallback to the appropriate portal logic depending on which type of portal I'm going through, even if I want to just override a single PortalLogic component. In what cases would you have more than two portals added to the rules set of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to introduce teleport behavior on PortalLogic so that it has an understanding of what to do with the block that is discovered as part of the destination portal. In vanilla, this block is used to linearly interpolate the spot in the portal that matches relatively to the entry point in the entrance portal. This is the default behavior of this PortalLogic in my followup implementation PR.