amplitude cutoff should require amplitude scalings extension#4513
Open
Julie-Fabre wants to merge 1 commit into
Open
amplitude cutoff should require amplitude scalings extension#4513Julie-Fabre wants to merge 1 commit into
Julie-Fabre wants to merge 1 commit into
Conversation
Member
|
I think I am OK with this a metrics should refer to only on thing. |
alejoe91
added
postprocessing
Member
|
For reproducibility it makes sense to rely on only one thing. But I am a bit worried about past users that may have determined their amplitudes previously without scalings. If they want to recalculate this then we error. We allow templates to be fast templates or based on waveforms so we aren't completely strict on this. I suppose I could go either way in the end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal (please close if you don't agree) to require amplitude scalings for the amplitude cutoff metric.
I also modified in conftest.py make_small_analyzer & sorting_analyzer_simple to have amplitude scalings - let me know if that's right, I am not sure.