Refactor received header parsing: replace regex list with RFC 5321 to…#150
Open
fedelemantuano wants to merge 1 commit intodevelopfrom
Open
Refactor received header parsing: replace regex list with RFC 5321 to…#150fedelemantuano wants to merge 1 commit intodevelopfrom
fedelemantuano wants to merge 1 commit intodevelopfrom
Conversation
…kenizer Replace the 10 separate regex patterns (each duplicating boundary lookaheads) with a keyword-based tokenizer aligned with RFC 5321 §4.4 grammar. Key improvements: - Tokenize on clause keywords (from/by/via/with/id/for) in a single pass instead of running 10 independent regex searches - Handle IBM "for <addr> from <sender>" by accepting only the first 'from' clause per header - Extract envelope-from/sender from parenthesized comments in clause values - Validate IPv4 octets (0-255) instead of matching any digits; add IPv6 support via REGXIP6 - Simplify JUNK_PATTERN to only collapse tabs/newlines, preserving parenthesized comments and bracketed IPs - Add 27-test corpus covering Postfix, Exim, Exchange, Gmail, SendGrid, IBM/Domino, AWS SES, and edge cases https://claude.ai/code/session_01CwmwWkvZGLpTBY6ApKFi79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…kenizer
Replace the 10 separate regex patterns (each duplicating boundary lookaheads) with a keyword-based tokenizer aligned with RFC 5321 §4.4 grammar. Key improvements:
https://claude.ai/code/session_01CwmwWkvZGLpTBY6ApKFi79