SCANPY-259 Refactor API download exception tests - #327
Closed
rombirli wants to merge 1 commit into
Closed
Conversation
Co-authored-by: rombirli <rombirli@users.noreply.github.com>
hashicorp-vault-sonar-prod
Bot
changed the title
Code Review ✅ ApprovedRefactors API download exception tests to isolate API calls from setup logic by pre-creating file handles. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of
Summary
assertRaisescontexts in API unit testsBytesIOhandles so exception assertions contain only the API call under testVerification
python3 -m pytest tests/unit/test_api.pySlack Thread