Editor card - plus add to rdfxml and n3 - #738
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a reusable “editor card” web component and updates the RDF/XML and N3 panes to render their serialized output through that shared editor wrapper, aligning their UI with the existing source-pane editor presentation.
Changes:
- Added
solid-panes-editor-card(Lit +solid-uiCodeEditor) as a generic wrapper component for read-only code display. - Refactored
RDFXMLPaneandn3Paneto use the editor card instead of bespoke line/indent rendering. - Simplified pane CSS now that formatting/scrolling is handled by the shared editor component.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/RDFXMLPane.ts | Switch RDF/XML rendering to the new editor-card component. |
| src/RDFXMLPane.css | Remove legacy source/indent styling; keep only container styling. |
| src/n3Pane.ts | Switch N3 rendering to the new editor-card component. |
| src/n3Pane.css | Remove legacy source/indent styling; keep only container styling. |
| src/components/editor-card/EditorCard.ts | New generic editor-card web component that lazy-loads and initializes CodeEditor. |
| src/components/editor-card/EditorCard.styles.css | Styles for the new editor-card component layout/padding. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SharonStrats
force-pushed
the
feat/add-editor
branch
2 times, most recently
from
August 15, 2026 08:14
bfe9d12 to
03345ca
Compare
SharonStrats
force-pushed
the
feat/add-editor
branch
from
August 15, 2026 08:23
36b2791 to
5a47f57
Compare
…@3.1.3-17 pane-registry@3.1.2-2 activitystreams-pane@1.0.3-4 chat-pane@3.0.4-3 contacts-pane@3.2.1-6 folder-pane@3.1.1-3 issue-pane@3.0.3-1 meeting-pane@3.0.3-1 profile-pane@3.2.3-4 source-pane@3.1.1-7) (latest: rdflib@2.4.0)
SharonStrats
marked this pull request as draft
August 16, 2026 08:38
SharonStrats
marked this pull request as ready for review
August 18, 2026 08:55
…@3.1.3-17 pane-registry@3.1.2-2 activitystreams-pane@1.0.3-4 chat-pane@3.0.4-3 contacts-pane@3.2.1-6 folder-pane@3.1.1-3 issue-pane@3.0.3-1 meeting-pane@3.0.3-1 profile-pane@3.2.3-4 source-pane@3.1.1-7) (latest: rdflib@2.4.0)
Member
|
I am not sure I follow, do you havea. screenshot? |
timea-solid
approved these changes
Aug 20, 2026
timea-solid
left a comment
timea-solid
left a comment
Member
There was a problem hiding this comment.
Interesting solution. Looks nice.
…@5.0.0-0 pane-registry@5.0.0-0 activitystreams-pane@2.0.0-0 chat-pane@4.0.0-0 contacts-pane@4.0.0-0 folder-pane@4.0.0-0 issue-pane@4.0.0-0 meeting-pane@4.0.0-0 profile-pane@4.0.0-0 source-pane@4.0.0-0) (latest: rdflib@2.4.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a generic editor card as a wrapper for the editor.
Used it in rdfxml and n3 panes so they look consistent with the source pane.
Note: Due to the way the design is and keeping things simple with current code structure, I just added the editor to the pane instead of incorporating rdfxml and n3 into source-pane.
Images of new look
rdfxml
n3