test(cli): pin ListArgs flag surface + run() error/empty/populated paths#77
Closed
Mikola Lysenko (mikolalysenko) wants to merge 2 commits into
Closed
test(cli): pin ListArgs flag surface + run() error/empty/populated paths#77Mikola Lysenko (mikolalysenko) wants to merge 2 commits into
Mikola Lysenko (mikolalysenko) wants to merge 2 commits into
Conversation
Sets up the foundation for a comprehensive unit-test campaign on the
socket-patch CLI. No behavior change to the binary.
Two changes:
1. Expose the clap parser as a library so integration tests can verify
the public CLI contract without spawning the binary:
- new crates/socket-patch-cli/src/lib.rs hosting Cli, Commands,
looks_like_uuid, and parse_with_uuid_fallback (extracted from main.rs)
- Cargo.toml gains [lib] entry alongside the existing [[bin]]
- main.rs is now a thin wrapper that delegates to the lib
2. De-duplicate the manifest-path resolution block that was copy-pasted
into 5 commands (apply, rollback, list, remove, repair). New helper
socket_patch_core::manifest::operations::resolve_manifest_path
handles the absolute-vs-relative join in one place, with 3 unit tests.
3. New CLI_CONTRACT.md next to the crate documenting every subcommand,
flag, default, alias, JSON shape, and exit code as semver-significant
surface. Adds a comment block above pub enum Commands pointing to it
so anyone editing the parser sees the contract reminder.
Verified: cargo build/clippy/test --workspace --all-features all clean
(415 unit tests pass, including 3 new resolve_manifest_path tests).
Foundation for follow-up PRs that add the per-command parser snapshot
tests and helper unit tests.
Assisted-by: Claude Code:claude-opus-4-7
Mikola Lysenko (mikolalysenko)
force-pushed
the
tests/cli-contract-foundation
branch
from
0bd4f50 to
6cb84b8
Compare
Adds tests/cli_parse_list.rs covering the public contract for `socket-patch
list`:
- clap parser tests pin each ListArgs flag (long + short forms), assert the
defaults from CLI_CONTRACT.md, and verify unknown flags surface
ErrorKind::UnknownArgument.
- async run() tests exercise the no-network branches against tempdirs:
missing manifest (exit 1, plain + json), empty manifest (exit 0, plain +
json), populated manifest (exit 0, plain + json), and an absolute
--manifest-path overriding --cwd.
- one subprocess test invokes the compiled binary against a missing-manifest
tempdir with --json and parses stdout to lock the
{ status: "error", error: "Manifest not found", path: ... } shape, since
run() writes to the real stdout and cannot be captured in-process.
Assisted-by: Claude Code:claude-opus-4-7
Mikola Lysenko (mikolalysenko)
force-pushed
the
tests/cli-parse-list
branch
from
486ca80 to
2df88c5
Compare
Mikola Lysenko (mikolalysenko)
force-pushed
the
tests/cli-contract-foundation
branch
from
6cb84b8 to
ef0deac
Compare
Contributor
Author
|
Squashed into #68. All tests from this PR are now part of the single combined commit on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
crates/socket-patch-cli/tests/cli_parse_list.rsto lock in the publicCLI contract for
socket-patch list. This is the second branch in the stackedCLI-contract test campaign on top of #67.
ListArgsflag (long + short), the defaults fromCLI_CONTRACT.md(cwd = ".",manifest_path = ".socket/manifest.json",json = false), and assert unknown flags surfaceclap::error::ErrorKind::UnknownArgument.run()tests cover the no-network branches against tempdirs:missing manifest (exit 1, plain + json), empty manifest (exit 0, plain +
json), populated manifest (exit 0, plain + json), and absolute
--manifest-pathoverriding--cwd.tempdir with
--jsonand parses stdout to lock the missing-manifest JSONshape (
status = "error",error = "Manifest not found", pluspath),since
run()writes to the real stdout and cannot be captured in-process.listis the smallest of the manifest-reading commands and exercises all theno-network JSON paths that
removeandrepairwill reuse, so locking itdown first gives the rest of the campaign a clean reference shape.
Test plan
cargo build --workspace --all-featurescleancargo test -p socket-patch-cli --test cli_parse_list— 14/14 passcargo test --workspace --all-features --lib --tests— all greentests/e2e_{npm,pypi,gem}.rsare unchanged and out of scope here)Assisted-by: Claude Code:claude-opus-4-7