test(cli): unit-test partition_purls ecosystem filter#70
Closed
Mikola Lysenko (mikolalysenko) wants to merge 2 commits into
Closed
test(cli): unit-test partition_purls ecosystem filter#70Mikola Lysenko (mikolalysenko) wants to merge 2 commits into
Mikola Lysenko (mikolalysenko) wants to merge 2 commits into
Conversation
Sets up the foundation for a comprehensive unit-test campaign on the
socket-patch CLI. No behavior change to the binary.
Two changes:
1. Expose the clap parser as a library so integration tests can verify
the public CLI contract without spawning the binary:
- new crates/socket-patch-cli/src/lib.rs hosting Cli, Commands,
looks_like_uuid, and parse_with_uuid_fallback (extracted from main.rs)
- Cargo.toml gains [lib] entry alongside the existing [[bin]]
- main.rs is now a thin wrapper that delegates to the lib
2. De-duplicate the manifest-path resolution block that was copy-pasted
into 5 commands (apply, rollback, list, remove, repair). New helper
socket_patch_core::manifest::operations::resolve_manifest_path
handles the absolute-vs-relative join in one place, with 3 unit tests.
3. New CLI_CONTRACT.md next to the crate documenting every subcommand,
flag, default, alias, JSON shape, and exit code as semver-significant
surface. Adds a comment block above pub enum Commands pointing to it
so anyone editing the parser sees the contract reminder.
Verified: cargo build/clippy/test --workspace --all-features all clean
(415 unit tests pass, including 3 new resolve_manifest_path tests).
Foundation for follow-up PRs that add the per-command parser snapshot
tests and helper unit tests.
Assisted-by: Claude Code:claude-opus-4-7
Mikola Lysenko (mikolalysenko)
force-pushed
the
tests/cli-contract-foundation
branch
from
0bd4f50 to
6cb84b8
Compare
Adds a #[cfg(test)] mod tests block at the bottom of crates/socket-patch-cli/src/ecosystem_dispatch.rs covering the partition_purls helper that splits PURLs by ecosystem and applies the --ecosystems allow-list filter for apply/rollback/scan. Nine cases: - No filter, single npm PURL groups into Ecosystem::Npm. - No filter, mixed npm/pypi/cargo PURLs each land in their own bucket. - No filter, empty input returns an empty map. - No filter, duplicate PURLs are preserved (no dedupe). - No filter, unrecognized "pkg:weirdo/..." is dropped. - Allow-list ["npm"] excludes pypi PURLs. - Allow-list ["pypi"] against an npm-only input returns empty. - Allow-list ["npm","pypi"] keeps both buckets. - Empty allow-list Some(&[]) matches nothing. No production code changed; no filesystem-touching helpers exercised. Verified: cargo build/clippy/test --workspace --all-features all clean (9 new tests pass). Assisted-by: Claude Code:claude-opus-4-7
Mikola Lysenko (mikolalysenko)
force-pushed
the
tests/cli-parse-ecosystem
branch
from
457f702 to
8e11cb8
Compare
Mikola Lysenko (mikolalysenko)
force-pushed
the
tests/cli-contract-foundation
branch
from
6cb84b8 to
ef0deac
Compare
Contributor
Author
|
Squashed into #68. All tests from this PR are now part of the single combined commit on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds nine unit tests for
partition_purlsincrates/socket-patch-cli/src/ecosystem_dispatch.rs.partition_purlsis the helper that splits the user-supplied PURL list by ecosystem and enforces the--ecosystemsCSV allow-list flag onapply,rollback, andscan, so it is on the hot path of the CLI contract.The new
#[cfg(test)] mod testsblock exercises onlypartition_purls. The neighboringfind_packages_for_purls,find_packages_for_rollback, andcrawl_all_ecosystemshelpers are intentionally not unit-tested here because they touch the filesystem — they are covered by integration tests elsewhere.Cases
Ecosystem::Npmbucket has the PURL.pkg:weirdo/...-> dropped, empty map.["npm"]against npm+pypi -> only the npm bucket.["pypi"]against npm-only -> empty map.["npm","pypi"]-> both buckets.Some(&[])-> empty map (matches nothing).PURL prefixes are verified against
Ecosystem::from_purlincrates/socket-patch-core/src/crawlers/types.rs; allow-list values matchEcosystem::cli_name()in the same file.Test plan
cargo build --workspace --all-featurescleancargo clippy --workspace --all-features -- -D warningscleancargo test --workspace --all-features --lib— all 9 new tests pass, existing tests still passStacked on #67 (
tests/cli-contract-foundation).