Fix 3 theme checks that produce false positives on Horizon theme#1168
Draft
graygilmore wants to merge 3 commits intomainfrom
Draft
Fix 3 theme checks that produce false positives on Horizon theme#1168graygilmore wants to merge 3 commits intomainfrom
graygilmore wants to merge 3 commits intomainfrom
Conversation
graygilmore
force-pushed
the
gg-fix-checks
branch
from
d99702d to
21d7cd5
Compare
These are platform-provided translations that themes don't control, matching the existing exclusion for shopify.* paths. Renamed isShopifyPath to isExternalPath to reflect the broader scope. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
graygilmore
force-pushed
the
gg-fix-checks
branch
from
21d7cd5 to
da93ee3
Compare
graygilmore
changed the title
graygilmore
changed the title
graygilmore
force-pushed
the
gg-fix-checks
branch
from
da93ee3 to
716554e
Compare
graygilmore
changed the title
…Target Local blocks (type names starting with _) reference files in the blocks/ directory and don't need explicit declaration in a section's root-level blocks array. Sections that define block hierarchies purely through presets are a valid pattern. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ment Add a cross-identifier balancing pass that matches unmatched opens from one conditional against unmatched closes from a sibling conditional within the same grandparent. This handles patterns where one condition opens a tag and a different condition closes it — e.g. forloop.first opens a wrapper div and forloop.last closes it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
graygilmore
force-pushed
the
gg-fix-checks
branch
from
716554e to
9a32784
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 3 theme checks that produce false positives on valid Liquid patterns:
customer_accounts.*translation paths (like the existingshopify.*exclusion) — these are platform-provided translations that themes don't control_name) in presets when no root-levelblocksarray exists — local blocks reference files inblocks/and don't need explicit declarationforloop.firstopens a wrapper div andforloop.lastcloses it)Test plan
npx vitest run packages/theme-check-common/src/checks/matching-translations/index.spec.ts— 18 tests passnpx vitest run packages/theme-check-common/src/checks/valid-block-target/index.spec.ts— 68 tests passnpx vitest run packages/theme-check-common/src/checks/unclosed-html-element/index.spec.ts— 11 tests pass🤖 Generated with Claude Code