Use Rubydex graph for constants_from_requested_paths#2608
Open
Morriar wants to merge 1 commit intoat-rubydex-bootstrapfrom
Open
Use Rubydex graph for constants_from_requested_paths#2608Morriar wants to merge 1 commit intoat-rubydex-bootstrapfrom
Morriar wants to merge 1 commit intoat-rubydex-bootstrapfrom
Conversation
Morriar
force-pushed
the
at-rubydex-payload
branch
from
e11a3ff to
5fa9e45
Compare
vinistock
approved these changes
Apr 23, 2026
Member
vinistock
left a comment
vinistock
left a comment
There was a problem hiding this comment.
It looks like there's some engine filtering that's failing, but I think it's related to the base branch and not this one
Morriar
force-pushed
the
at-rubydex-bootstrap
branch
2 times, most recently
from
2f75610 to
722d240
Compare
Morriar
force-pushed
the
at-rubydex-payload
branch
2 times, most recently
from
4da3e75 to
05bd763
Compare
Morriar
force-pushed
the
at-rubydex-bootstrap
branch
from
722d240 to
241a2da
Compare
Morriar
force-pushed
the
at-rubydex-payload
branch
from
05bd763 to
d771ba3
Compare
st0012
approved these changes
May 6, 2026
Morriar
force-pushed
the
at-rubydex-bootstrap
branch
from
241a2da to
f24d943
Compare
Morriar
force-pushed
the
at-rubydex-payload
branch
from
d771ba3 to
b868efc
Compare
Morriar
force-pushed
the
at-rubydex-bootstrap
branch
from
f24d943 to
3649e0b
Compare
Morriar
force-pushed
the
at-rubydex-payload
branch
from
b868efc to
f74bd6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracted from #2524. Instead of shelling out to Sorbet to get the symbol table for requested paths, we use the Rubydex graph which is already available and faster.
symbols_from_paths(Sorbet shell-out) withgraph_from_paths(Rubydex) inconstants_from_requested_pathssymbols_from_pathsmethod fromSymbolLoader