Open
Conversation
vinistock
reviewed
Apr 23, 2026
eeebd71 to
2f75610
Compare
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
2f75610 to
722d240
Compare
vinistock
approved these changes
May 5, 2026
Member
vinistock
left a comment
There was a problem hiding this comment.
Do we still need the include_doc flag? If memory serves, we added that because including docs was super slow, but with Rubydex the problem no longer exists.
Maybe we can clean up that flag
241a2da to
f24d943
Compare
f24d943 to
3649e0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracted from #2524. Instead of shelling out to Sorbet to get the symbol table for a gem's files, we use the Rubydex graph which is already available and faster. The engine symbols path also switches to Rubydex for consistency.
symbols_from_paths) with Rubydex graph for bootstrapping gem symbols in the pipelineinclude_doc), and reused for both symbol bootstrapping and documentationgem_symbolsfromSymbolLoaderandload_bootstrap_symbolsfromPipelinesince Rubydex handles both cases