Skip to content

Bootstrap gem symbols from Rubydex graph#2607

Open
Morriar wants to merge 2 commits intomainfrom
at-rubydex-bootstrap
Open

Bootstrap gem symbols from Rubydex graph#2607
Morriar wants to merge 2 commits intomainfrom
at-rubydex-bootstrap

Conversation

@Morriar
Copy link
Copy Markdown
Contributor

@Morriar Morriar commented Apr 23, 2026

Summary

Extracted from #2524. Instead of shelling out to Sorbet to get the symbol table for a gem's files, we use the Rubydex graph which is already available and faster. The engine symbols path also switches to Rubydex for consistency.

  • Replace Sorbet's symbol table (symbols_from_paths) with Rubydex graph for bootstrapping gem symbols in the pipeline
  • The gem graph is now always built (not conditional on include_doc), and reused for both symbol bootstrapping and documentation
  • Remove gem_symbols from SymbolLoader and load_bootstrap_symbols from Pipeline since Rubydex handles both cases

@Morriar Morriar requested a review from a team as a code owner April 23, 2026 07:10
@Morriar Morriar added the chore label Apr 23, 2026
Comment thread lib/tapioca/static/symbol_loader.rb Outdated
@Morriar Morriar force-pushed the at-rubydex-bootstrap branch from eeebd71 to 2f75610 Compare May 5, 2026 15:29
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar force-pushed the at-rubydex-bootstrap branch from 2f75610 to 722d240 Compare May 5, 2026 15:58
Copy link
Copy Markdown
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the include_doc flag? If memory serves, we added that because including docs was super slow, but with Rubydex the problem no longer exists.

Maybe we can clean up that flag

@Morriar Morriar force-pushed the at-rubydex-bootstrap branch 2 times, most recently from 241a2da to f24d943 Compare May 6, 2026 14:58
@Morriar Morriar force-pushed the at-rubydex-bootstrap branch from f24d943 to 3649e0b Compare May 6, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants