Conversation
aaf2cc7 to
7992177
Compare
|
|
||
| module ShopifyAPI | ||
| module Utils | ||
| class ShopValidator |
There was a problem hiding this comment.
There's also a similar sanitize method from shopify_app gem, I wonder if the logic can be extracted so we don't have to maintain 2 packages for validating Shopify URLS
There was a problem hiding this comment.
I've finally copied the code from there. Once we release a new version, we could use it from shopify_app, as it's already using shopify-api-ruby. Makes sense?
7992177 to
66cb7f4
Compare
66cb7f4 to
d51f23a
Compare
| requested_token_type: RequestedTokenType, | ||
| ).returns(ShopifyAPI::Auth::Session) | ||
| end | ||
| def exchange_token(shop:, session_token:, requested_token_type:) |
There was a problem hiding this comment.
I would prefer we don't remove this in this PR. But rather log a warning that this will be remove in a future version. i.e we should deprecate now remove later.
This will allow us to group our breaking changes together.
ShopifyAPI::Logger.deprecated(
"The `shop` parameter for `exchange_token` is deprecated and will be removed in v17. " \
"The shop is now always taken from the session token's `dest` claim.",
"17.0.0"
)
There was a problem hiding this comment.
Oh, sorry, I misread your previous comment. Updated!
d51f23a to
89b2da5
Compare
Description
https://docs.google.com/document/d/1c0iXhKBpm-yhvff0iSgq1XwBSPL39fTBVajIJ3svaxU/edit?usp=sharing
Checklist: