Open
Conversation
Encoding::UTF_32 doesn't actually encodes strings correctly and we were calculating code points with a wrong encoding. It's UTF_32LE that encodes the string and provides us the right locations back
…ivers (#4062) * Fix parent scope and method receiver resolution and tracking * Fix surrounding method call sites * Add more parent scope and method definition receiver tests
* Fix parent scope and method receiver resolution and tracking * Fix surrounding method call sites * Add more parent scope and method definition receiver tests * Migrate find references to Rubydex
* Prevent guessed types from being anything but namespaces
vinistock
added
breaking-change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is a formality at this point since all of the changes were reviewed one by one, but this PR merges the feature branch into main to migrate to Rubydex and fully remove the old indexer.