Skip to content

Revert SCOPE_OVER_REQUEST prompt changes from #8595 - #8633

Merged
lopez-mar merged 2 commits into
mainfrom
revert-8595-prompt-keep-versioning
Sep 24, 2026
Merged

lopez-mar merged 2 commits into
mainfrom
revert-8595-prompt-keep-versioning

Conversation

@lopez-mar

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Reverts the prompt changes from #8595 while keeping the changeset so a version bump still ships.

WHAT is this pull request doing?

Restores the SCOPE_OVER_REQUEST check prompt (back to version 1), the embedded source copy, and the catalog entry to their pre-#8595 state. The changeset from #8595 is kept (patch bump) but its text is updated to reflect that the prompt is being reverted rather than changed.

How to manually test your changes?

pnpm shopify app security check --path /path/to/app --json --skip-instructions
pnpm shopify app security instructions --path /path/to/app

@lopez-mar
lopez-mar requested a review from a team as a code owner September 23, 2026 22:09
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Sep 23, 2026
Restore the SCOPE_OVER_REQUEST check prompt (version 1), embedded
source, and catalog entry to their pre-#8595 state. Keep the changeset
so a version bump still ships, but update its text to reflect the
revert. Reverts the prompt changes from #8595 while preserving the
versioning.
@lopez-mar
lopez-mar force-pushed the revert-8595-prompt-keep-versioning branch from bf3e90b to 130f04c Compare September 23, 2026 22:12
@jplhomer
jplhomer requested a review from amcaplan September 24, 2026 14:24
Comment thread .changeset/evidence-based-scope-review.md Outdated
Per review feedback: the changeset only existed to trigger a version
bump, but other pending changesets already handle that. Remove it.
@lopez-mar
lopez-mar enabled auto-merge September 24, 2026 16:31
@lopez-mar
lopez-mar added this pull request to the merge queue Sep 24, 2026
Merged via the queue into main with commit 2b35bfb Sep 24, 2026
30 checks passed
@lopez-mar
lopez-mar deleted the revert-8595-prompt-keep-versioning branch September 24, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants