[Tests] Cover manifest.json creation and merge behaviour - #8614
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
createOrUpdateManifestFileinpackages/app/src/cli/services/build/steps/include-assets/generate-manifest.tshad no direct test coverage. Its merge contract is what lets several build steps contribute to the samemanifest.json, and its recovery path is what keeps a corrupt manifest from failing a build — but both were only reachable throughinclude-assets-steptests that always start from an empty output directory, so the merge and recovery branches were never exercised.bundle-ui-step.test.tsmocks the module out entirely.WHAT is this pull request doing?
Adds a co-located test file for
generate-manifest.tscovering the two exported functions at their public seam, using real temporary directories:resolveOutputDirfor both the file and directory forms of an extensionoutputPath.createOrUpdateManifestFilecreating the output directory when it does not exist, merging new fields into an existing entry, replacing an entry when either side is not a plain object, and starting fresh when the existingmanifest.jsonis not valid JSON.Each test was checked against a deliberately broken version of the corresponding branch to confirm it fails when the behaviour regresses. No production code changed.
How to manually test your changes?
CI
Post-release steps
None.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add