[Refactor] Extract adminUrl helper in themes/urls.ts - #8254
[Refactor] Extract adminUrl helper in themes/urls.ts#8254gonzaloriestra wants to merge 1 commit into
Conversation
Extract private helper function adminUrl to handle FQDN formatting and path appending, thereby eliminating redundant URL string interpolations across themeEditorUrl, codeEditorUrl, storeAdminUrl, and storePasswordPage.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The URL construction functions in
packages/cli-kit/src/public/node/themes/urls.tsrepeated the string interpolation logic for constructing store admin URLs (https://${store}/admin...).This PR refactors them by introducing a private helper function
adminUrlto centralize this formatting logic, improving maintainability and reducing code duplication.WHAT is this pull request doing?
adminUrl(store: string, path = ''): stringhelper function.themeEditorUrl,codeEditorUrl,storeAdminUrl, andstorePasswordPageto delegate URL generation toadminUrl.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 11628264692596972264 started by @gonzaloriestra