Skip to content

feat: add shareable evaluation prompt links#584

Merged
adibarra merged 4 commits into
masterfrom
feat/eval-share
Jul 18, 2026
Merged

feat: add shareable evaluation prompt links#584
adibarra merged 4 commits into
masterfrom
feat/eval-share

Conversation

@adibarra

@adibarra adibarra commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add Share buttons for evaluation prompt drawers and individual samples
  • restore shared drawers and expanded samples from URL parameters
  • resolve shared samples to the correct paginated result page
  • add English and Chinese labels for the new controls

Testing

  • pnpm typecheck
  • pnpm fmt
  • pnpm exec cypress run --spec cypress/e2e/evaluation-chart.cy.ts (15 passing)

Note

Low Risk
Read-only sharing and a narrow API extension on eval samples; no auth or data mutation paths.

Overview
Adds shareable URLs for evaluation per-sample drawers on the evaluation table view. Users can copy links that open a specific eval run (eval) and optionally one expanded sample (sample); share controls are limited to DB-backed official runs.

Deep linking: EvaluationTable reads eval / sample on load, opens the samples drawer for the matching row, and strips those params when the drawer closes. Manually opening a row clears shared state so a lone sample query param does not auto-expand a sample.

Pagination: /api/v1/eval-samples accepts optional doc_id, uses new getEvalSampleOffset to return the page containing that sample (and offset in the response). The drawer uses this to jump pages, expand, and scroll the target sample into view.

E2E: Cypress coverage for drawer-only links, sample links, and stale-sample behavior.

Reviewed by Cursor Bugbot for commit 555aae7. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Jul 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
inferencemax-app Ready Ready Preview, Comment Jul 18, 2026 1:19am

Request Review

Comment thread packages/app/src/components/evaluation/ui/EvaluationTable.tsx Outdated
@blacksmith-sh

This comment has been minimized.

Comment thread packages/app/src/components/evaluation/ui/EvaluationTable.tsx
Comment thread packages/app/src/components/evaluation/ui/EvalSamplesDrawer.tsx
@adibarra
adibarra merged commit 466a44a into master Jul 18, 2026
21 of 22 checks passed
@adibarra
adibarra deleted the feat/eval-share branch July 18, 2026 01:18

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 555aae7. Configure here.

?.scrollIntoView({ block: 'center' });
});
setRequestedDocId(null);
}, [data, requestedDocId]);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared sample errors stick drawer

Medium Severity

requestedDocId is cleared only after a successful response that contains the sample. When the API returns 404 for a missing doc_id, or the sample never appears in data, that id stays set, so later page and filter requests keep sending it and the drawer remains stuck on the load error until it is closed and reopened.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 555aae7. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant