feat: add shareable evaluation prompt links#584
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 555aae7. Configure here.
| ?.scrollIntoView({ block: 'center' }); | ||
| }); | ||
| setRequestedDocId(null); | ||
| }, [data, requestedDocId]); |
There was a problem hiding this comment.
Shared sample errors stick drawer
Medium Severity
requestedDocId is cleared only after a successful response that contains the sample. When the API returns 404 for a missing doc_id, or the sample never appears in data, that id stays set, so later page and filter requests keep sending it and the drawer remains stuck on the load error until it is closed and reopened.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 555aae7. Configure here.


Summary
Testing
pnpm typecheckpnpm fmtpnpm exec cypress run --spec cypress/e2e/evaluation-chart.cy.ts(15 passing)Note
Low Risk
Read-only sharing and a narrow API extension on eval samples; no auth or data mutation paths.
Overview
Adds shareable URLs for evaluation per-sample drawers on the evaluation table view. Users can copy links that open a specific eval run (
eval) and optionally one expanded sample (sample); share controls are limited to DB-backed official runs.Deep linking:
EvaluationTablereadseval/sampleon load, opens the samples drawer for the matching row, and strips those params when the drawer closes. Manually opening a row clears shared state so a lonesamplequery param does not auto-expand a sample.Pagination:
/api/v1/eval-samplesaccepts optionaldoc_id, uses newgetEvalSampleOffsetto return the page containing that sample (andoffsetin the response). The drawer uses this to jump pages, expand, and scroll the target sample into view.E2E: Cypress coverage for drawer-only links, sample links, and stale-sample behavior.
Reviewed by Cursor Bugbot for commit 555aae7. Bugbot is set up for automated code reviews on this repo. Configure here.