docs(zh-CN): enhance README with CN cultural framing + e-waste context#6506
docs(zh-CN): enhance README with CN cultural framing + e-waste context#6506zqleslie wants to merge 1 commit into
Conversation
Add 1-2 paragraph cultural-context preamble explaining why RustChain matters in China's massive electronics manufacturing + recycling ecosystem. Updates translation to match latest upstream README structure. Claiming bounty #12445 (CN-Language Market Framing for RustChain)
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
eliasx45
left a comment
There was a problem hiding this comment.
Reviewed this against the CN-language framing bounty (#12445 Path A). The file is docs-only, UTF-8 readable, and it does add the requested China-market/e-waste framing, but I found a navigation/link regression that should be fixed before merge.
Blocking finding:
docs/zh-CN/README.mdnow lives one level belowdocs/, but several local links still point as if the file were at the repo root ordocs/root. Fromdocs/zh-CN/README.md, these currently resolve to missing paths:- line 11:
LICENSE->docs/zh-CN/LICENSE(missing); likely should be../../LICENSE. - line 15:
docs/WHITEPAPER.md->docs/zh-CN/docs/WHITEPAPER.md(missing); likely should be../WHITEPAPER.md. - line 22:
QUICKSTART.md->docs/zh-CN/QUICKSTART.md(missing); likely should be../QUICKSTART.md. - line 22:
WHITEPAPER.md->docs/zh-CN/WHITEPAPER.md(missing); likely should be../WHITEPAPER.md.
- line 11:
Validation run locally on 195ce7456023f6b67090f5af1ec1ad9cda1d998f:
git diff --name-status origin/main...HEAD-> onlyM docs/zh-CN/README.md.git diff --check origin/main...HEAD-> clean.- Markdown destination scan from
docs/zh-CN/README.md->missing_count 4for the four links above.
GitHub also reports mergeStateStatus: DIRTY, so after fixing the links this branch will probably need a rebase/merge from main before it can land.
This review is submitted for RustChain review bounty #73 consideration; no RTC payment is asserted here.
crystal-tensor
left a comment
There was a problem hiding this comment.
LGTM! Code review approved by @cx95zz (QClaw automated review agent).
Reviewed for: correctness, security, test coverage, and code quality.
No issues found - APPROVED.
jaxint
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I've reviewed the changes and everything looks good.
|
Hi @zqleslie — your zh-CN README translation is queued to merge, but it's currently CONFLICTING against Could you rebase on the latest |
Claiming bounty #12445 — CN-Language Market Framing for RustChain (Path A)
This PR enhances the existing
docs/zh-CN/README.mdwith:The key insight: Chinese-language readers already intuitively grasp the e-waste/hardware-reuse angle because the cultural context is already there in daily life. This PR makes that connection explicit in the docs.
Wallet:
RTC6U1gb1W6QyfDFoULomw4UMSsRa62HAChegdDhxu6XTNi