refactor: do not use internal API in several places#1318
Closed
AayushSabharwal wants to merge 3 commits intoSciML:masterfrom
Closed
refactor: do not use internal API in several places#1318AayushSabharwal wants to merge 3 commits intoSciML:masterfrom
AayushSabharwal wants to merge 3 commits intoSciML:masterfrom
Conversation
4 tasks
Member
|
#1319 the spatial failures are real |
Member
|
Currently, we disallow creating spatial lattice models for cases with vector species/parameters. Not because I think it strictly won't work, but because I am not 100% certain that there are not some corner case, and at the time there was not oppertunity to go through and write ll the tests. Checking the error, I think what have happened is that there is an error check throwing an error when you have a array vriable input, and using the updated code, that error is not triggered. I.e. these should be errors. let
tr = @transport_reaction D Y
rs1 = @reaction_network begin
@species X(t)[1:2] Y(t)
(k1,k2), X[1] <--> X[2]
end
@test_throws ArgumentError LatticeReactionSystem(rs1, [tr], CartesianGrid((2,2)))
rs2 = @reaction_network begin
@species Y(t)
@parameters k[1:2,1:2]
(k[1,1],k[1,2]), X11 <--> X12
(k[2,1],k[2,2]), X21 <--> X22
end
@test_throws ArgumentError LatticeReactionSystem(rs2, [tr], CartesianGrid((2,2)))
end |
Member
|
Closing as I think this has all been handled, but feel free to let us know if there are more internals we should stop using. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.