Skip to content

build(deps): update github.com/Scalingo/go-scalingo from v10 to v11#1203

Merged
EtienneM merged 1 commit intomasterfrom
fix/1147/private_networks_pagination
Mar 23, 2026
Merged

build(deps): update github.com/Scalingo/go-scalingo from v10 to v11#1203
EtienneM merged 1 commit intomasterfrom
fix/1147/private_networks_pagination

Conversation

@EtienneM
Copy link
Member

@EtienneM EtienneM commented Mar 11, 2026

Fix #1147

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@EtienneM EtienneM self-assigned this Mar 11, 2026
@EtienneM EtienneM force-pushed the fix/1147/private_networks_pagination branch 3 times, most recently from f1978d4 to 3c06886 Compare March 11, 2026 10:37
@EtienneM EtienneM force-pushed the fix/1147/private_networks_pagination branch from 3c06886 to ec404a4 Compare March 11, 2026 10:48
@EtienneM EtienneM force-pushed the fix/1147/private_networks_pagination branch 3 times, most recently from d8e2fb6 to 33800da Compare March 20, 2026 13:44
@EtienneM EtienneM force-pushed the fix/1147/private_networks_pagination branch 5 times, most recently from d1a28a7 to f32b972 Compare March 23, 2026 07:50
@EtienneM EtienneM changed the title fix(privatenetworks): PrivateNetworksDomainsList must take a pagination.Request in argument build(deps): update github.com/Scalingo/go-scalingo from v10 to v11 Mar 23, 2026
@EtienneM EtienneM force-pushed the fix/1147/private_networks_pagination branch from f32b972 to 4624e40 Compare March 23, 2026 07:53
@EtienneM EtienneM marked this pull request as ready for review March 23, 2026 07:57
@EtienneM EtienneM requested a review from a team as a code owner March 23, 2026 07:57
@EtienneM EtienneM requested review from a team, curzolapierre and sc-zenokerr and removed request for a team and sc-zenokerr March 23, 2026 07:57
Copy link
Contributor

@SCedricThomas SCedricThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EtienneM EtienneM merged commit 8e323f6 into master Mar 23, 2026
7 checks passed
@EtienneM EtienneM deleted the fix/1147/private_networks_pagination branch March 23, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[factor]: pagination arguments and logic is duplicated across multiple commands. Factor it to a single place.

2 participants