Update GCF output string for encrypted GCFs#417
Merged
Conversation
| string fileName = Path.GetFileName(file); | ||
| uint depotId = _wrapper.Model.Header.CacheID; | ||
| uint manifestVersion = _wrapper.Model.Header.LastVersionPlayed; | ||
| uint depotVersion = _wrapper.Model.Header.LastVersionPlayed; |
Contributor
Author
There was a problem hiding this comment.
Updated terminology in code slightly; calling a steam2 version a manifest is possibly inaccurate.
| uint manifestVersion = _wrapper.Model.Header.LastVersionPlayed; | ||
| uint depotVersion = _wrapper.Model.Header.LastVersionPlayed; | ||
|
|
||
| // At the moment, all samples of GCF files on redump are unencrypted. Combined with being uncertain about |
Contributor
Author
There was a problem hiding this comment.
This was wrong, there are plenty of encrypted GCFs on redump already.
| // string returnString = $"{fileName} - {depotId} (v{manifestVersion}, {encryptedString})"; | ||
|
|
||
| string returnString = $"{fileName} - {depotId} (v{manifestVersion})"; | ||
| // Only note encryption status if the GCF is encrypted |
Contributor
Author
There was a problem hiding this comment.
If you feel otherwise, let me know, but it seems redundant to put a string saying it's unencrypted, imo it's better to just only note it when it's encrypted.
Member
There was a problem hiding this comment.
I don't really have a good enough grasp on the file type to know if stating that it is unencrypted is valuable or not. At the very least, it can be tweaked here if necessary.
mnadareski
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not even remotely a priority, this is a minor change and I just wanted to push it before I forgot about it. You obv have much more important things to work on at the moment.
Updates GCF output string to note when the GCF is encrypted. I was wrong that there aren't many encrypted GCFs, there's a bunch.