feat: [OpenAPI] Make Spring Optional with Apache HttpClient #1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpanackal
force-pushed
the
feat/openapi/optional-spring-base
branch
from
f47b1db to
cde369f
Compare
newtork
reviewed
Dec 30, 2025
...sample/src/main/java/com/sap/cloud/sdk/datamodel/openapi/apache/sodastore/api/OrdersApi.java
Show resolved
Hide resolved
newtork
reviewed
Dec 30, 2025
| * @throws ApiException | ||
| * if fails to make API call | ||
| */ | ||
| public Order ordersPost( @javax.annotation.Nonnull Order order ) |
Contributor
There was a problem hiding this comment.
(Question/Optional)
It may be worth our time to check for alternatives to javax.annotation.Nonnull null-indicator annotations.
Member
Author
There was a problem hiding this comment.
Surely Jspecify is an option. But I guess that would merit a larger refactoring throughout the sdk
newtork
reviewed
Dec 30, 2025
...he-sample/src/main/java/com/sap/cloud/sdk/datamodel/openapi/apache/sample/api/OrdersApi.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Dec 30, 2025
...che-sample/src/main/java/com/sap/cloud/sdk/datamodel/openapi/apache/sample/api/SodasApi.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Dec 30, 2025
...che-sample/src/main/java/com/sap/cloud/sdk/datamodel/openapi/apache/sample/api/SodasApi.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Dec 30, 2025
...-sample/src/main/java/com/sap/cloud/sdk/datamodel/openapi/apache/sodastore/api/SodasApi.java
Show resolved
Hide resolved
newtork
reviewed
Dec 30, 2025
...e-sample/src/main/java/com/sap/cloud/sdk/datamodel/openapi/apache/sodastore/model/Fanta.java
Show resolved
Hide resolved
newtork
reviewed
Dec 30, 2025
...el/openapi/openapi-core/src/main/java/com/sap/cloud/sdk/services/openapi/apache/BaseApi.java
Outdated
Show resolved
Hide resolved
|
SAP employees are expected to use their SAP-email address for commits related to their work. Our compliance check has detected usage of an email other than a SAP one by a SAP employee. Please update your pull request accordingly. If you think this is wrong or need any assistance, please contact [email protected]. |
Contributor
CharlesDuboisSAP
left a comment
CharlesDuboisSAP
left a comment
There was a problem hiding this comment.
Could we see it in AI SDK?
...che-sample/src/main/java/com/sap/cloud/sdk/datamodel/openapi/apache/sample/api/SodasApi.java
Outdated
Show resolved
Hide resolved
...-sample/src/main/java/com/sap/cloud/sdk/datamodel/openapi/apache/sodastore/api/SodasApi.java
Show resolved
Hide resolved
.../openapi/openapi-core/src/main/java/com/sap/cloud/sdk/services/openapi/apache/ApiClient.java
Outdated
Show resolved
Hide resolved
.../openapi/openapi-core/src/main/java/com/sap/cloud/sdk/services/openapi/apache/ApiClient.java
Show resolved
Hide resolved
...model/openapi/openapi-core/src/main/java/com/sap/cloud/sdk/services/openapi/apache/Pair.java
Show resolved
Hide resolved
...main/resources/openapi-generator/mustache-templates/libraries/apache-httpclient/api.mustache
Outdated
Show resolved
Hide resolved
.../openapi/openapi-core/src/main/java/com/sap/cloud/sdk/services/openapi/apache/ApiClient.java
Outdated
Show resolved
Hide resolved
Member
Author
@CharlesDuboisSAP You can checkout branch |
…-generator/mustache-templates/libraries/apache-httpclient/api.mustache Co-authored-by: Charles Dubois <[email protected]>
…e' into feat/openapi/optional-spring-base
…/services/openapi/apache/ApiClient.java Co-authored-by: Charles Dubois <[email protected]>
Contributor
CharlesDuboisSAP
left a comment
CharlesDuboisSAP
left a comment
There was a problem hiding this comment.
Some of the comments are also valid for Spring RestTemplate so optional
...rces/openapi-generator/mustache-templates/libraries/apache-httpclient/operationBody.mustache
Show resolved
Hide resolved
...main/resources/openapi-generator/mustache-templates/libraries/apache-httpclient/api.mustache
Outdated
Show resolved
Hide resolved
...rces/openapi-generator/mustache-templates/libraries/apache-httpclient/operationBody.mustache
Outdated
Show resolved
Hide resolved
…#1062) Moving to single larger PR (sorry), because its getting difficult to sync changes across. Both PRs have been thoroughly review at this point.
CharlesDuboisSAP
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
SAP/cloud-sdk-java-backlog#464.
There are two objectives to this PR
apache-httpclienttemplate based code generation. We will (soon) remove a large chunk of introduced files, reduce public API and even refactor code.To maintain backward compatibility Spring framework dependencies are marked optional but template files, or any public API are still maintained without any changes.
Feature scope:
com.sap.cloud.sdk.services.openapi.apachewithApiClient,BaseApiand other supporting classes addedopenapi-api-apache-samplemodule as e2e test with sample code generation with apache/ApiClientEdit: Merged features
Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated