Skip to content

chore: Enhance HttpClient5 Retry-Strategy for 429 and 503 responses #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
newtork merged 8 commits into from
Apr 27, 2026
+200 −1
Merged

chore: Enhance HttpClient5 Retry-Strategy for 429 and 503 responses #1009

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
148ce3f
Set default retry strategy to no-retries
newtork Nov 18, 2025
14be48f
Merge remote-tracking branch 'origin/main' into httpclient5/disable-r…
newtork Nov 18, 2025
7b6ff0d
Add retry log message
newtork Nov 20, 2025
dd02040
Merge remote-tracking branch 'origin/main' into httpclient5/disable-r…
newtork Nov 20, 2025
3d62efd
Merge remote-tracking branch 'origin/main' into httpclient5/disable-r…
newtork Apr 24, 2026
a337dce
Improve logging; Add test
newtork Apr 24, 2026
f4996ec
Update release_notes.md
newtork Apr 24, 2026
ec8cc93
Merge branch 'main' into httpclient5/disable-retry
MatKuhr Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...in/java/com/sap/cloud/sdk/cloudplatform/connectivity/DefaultApacheHttpClient5Factory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import org.apache.hc.client5.http.classic.HttpClient;
import org.apache.hc.client5.http.config.ConnectionConfig;
import org.apache.hc.client5.http.config.RequestConfig;
import org.apache.hc.client5.http.impl.DefaultHttpRequestRetryStrategy;
import org.apache.hc.client5.http.impl.classic.CloseableHttpClient;
import org.apache.hc.client5.http.impl.classic.HttpClientBuilder;
import org.apache.hc.client5.http.impl.classic.HttpClients;
Expand All @@ -26,6 +27,7 @@
import org.apache.hc.core5.http.HttpHost;
import org.apache.hc.core5.http.HttpRequestInterceptor;
import org.apache.hc.core5.http.io.SocketConfig;
import org.apache.hc.core5.util.TimeValue;
import org.apache.hc.core5.util.Timeout;

import com.sap.cloud.sdk.cloudplatform.connectivity.exception.DestinationAccessException;
Expand Down Expand Up @@ -92,6 +94,7 @@ private CloseableHttpClient buildHttpClient(
.custom()
.setConnectionManager(getConnectionManager(destination))
.setDefaultRequestConfig(requestConfig)
.setRetryStrategy(new DefaultHttpRequestRetryStrategy(0, TimeValue.ZERO_MILLISECONDS))
Comment thread
newtork marked this conversation as resolved.
Outdated
.setProxy(getProxy(destination));

if( requestInterceptor != null ) {
Expand Down