Skip to content

feat: [Batch]#850

Open
CharlesDuboisSAP wants to merge 22 commits intomainfrom
batch
Open

feat: [Batch]#850
CharlesDuboisSAP wants to merge 22 commits intomainfrom
batch

Conversation

@CharlesDuboisSAP
Copy link
Copy Markdown
Contributor

Context

AI/ai-sdk-java-backlog#385.

New module, new API

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

@CharlesDuboisSAP CharlesDuboisSAP self-assigned this May 6, 2026
@CharlesDuboisSAP CharlesDuboisSAP added the please-review Request to review a pull-request label May 6, 2026
Copy link
Copy Markdown
Member

@Jonas-Isr Jonas-Isr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this is more than a PoC. Looks like it could be released.

@jjtang1985 What do you think regarding releasing this?

Comment thread core-services/batch/pom.xml Outdated
Comment thread sample-code/spring-app/src/main/resources/static/index.html Outdated
RESOURCE_GROUP,
BatchCreateRequest.create()
.type(TypeEnum.LLM_NATIVE)
.input(BatchCreateRequestInput.create().uri("ai://s3secret/input-batch.jsonl"))
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I checked, even if we use PUT request of the File API to create a file on the fly, it still needs the s3 bucket to upload.

I was thinking to not have test data configured independently from the test so that tests do not rely on any data from outside.

I would create this file on the fly (fine if we override). But no strong opinion.

public static final String RESOURCE_GROUP = "ai-sdk-java-e2e";

/** Directory path for batch output files in the object store. */
public static final String S3_DIRECTORY = "s3secret//";
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I think the service team decide to put a / in front of the actual s3 file name if the output uri is ai://s3secret/.

2026-04-28 15:31:23       2582 /e3eb3a73-8072-404e-bc00-123412341234/output.jsonl
2026-04-15 16:43:39        407 file.txt

So /e3eb3a73-8072-404e-bc00-123412341234/output.jsonl should never have / at the beginning.

But if you change the output to ai://s3secret/output, it is actually correct:

2026-05-07 14:08:46       4002 output/fa173027-a1ed-4b70-a147-200fa159a98d/output.jsonl

This is IMO a bug from their side.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the output folder

CharlesDuboisSAP and others added 7 commits May 7, 2026 16:05
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Jonas-Isr <jonas.israel@sap.com>
Co-authored-by: Jonas-Isr <jonas.israel@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please-review Request to review a pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants