Add error/keypair modules and documentation for VRF crate (based on #1794)#1796
Open
omibo wants to merge 8 commits intoRustCrypto:masterfrom
Open
Add error/keypair modules and documentation for VRF crate (based on #1794)#1796omibo wants to merge 8 commits intoRustCrypto:masterfrom
omibo wants to merge 8 commits intoRustCrypto:masterfrom
Conversation
Contributor
|
I am not in favor of having an error type. Proving, verifying and hashing are all defined as infallible in RFC9381. Except for ECVRF proof to hash, where it can fail because of proof string deserialization. This is not a concern for us because we implement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the following to the draft proposed by @carloskiki in #1794 to the issue [#1728]:
Notes